search

bobafetthotmail / refind-theme-regular

http://munlik.deviantart.com/art/rEFInd-theme-512091944
Other
794 stars 78 forks source link

Add os_cachy icons #40

Closed adntaha closed 1 year ago

adntaha commented 1 year ago

CachyOS is a user-friendly and highly optimized distribution based on Arch Linux. I was able to use this svg as a base for the svg I've submitted.

adntaha commented 1 year ago

os_cachy just rings better. If you don't mind, since I've got more than one commit, can you squash this PR? Thanks.

bobafetthotmail commented 1 year ago

the file name is used by refind to select the right icon for the OS ("rEFInd attempts to guess the Linux distribution based on data in the /etc/os-release file. This file will only be accessible if a separate /boot partition is not used, though.", see http://www.rodsbooks.com/refind/configfile.html#icons and the name of the icon after the "os_" has to match that). I don't know if it works with both os_cachyos and os_cachy.

If you confirm that it actually works, I will merge it

bobafetthotmail commented 1 year ago

whatever, merged. If someone complains about this OS icon looking wrong we will figure it out then

ProjectInfinity commented 1 year ago

whatever, merged. If someone complains about this OS icon looking wrong we will figure it out then

I am the bearer of bad news. My install doesn't seem to be detected as Cachy at all.

Here's the os-release.

cat /etc/os-release NAME="CachyOS Linux" PRETTY_NAME="CachyOS" ID=cachyos ID_LIKE=arch BUILD_ID=rolling ANSI_COLOR="38;2;23;147;209" HOME_URL="https://cachyos.org/" DOCUMENTATION_URL="https://wiki.cachyos.org/" SUPPORT_URL="https://forum.cachyos.org/" BUG_REPORT_URL="https://github.com/cachyos" PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/" LOGO=cachyos

adntaha commented 1 year ago

Seems like os_cachy wasn't the correct one, but os_cachyos. Sorry about that!

Mar 23, 2023 6:58:39 PM Infinity @.***>:

whatever, merged. If someone complains about this OS icon looking wrong we will figure it out then

I am the bearer of bad news. My install doesn't seem to be detected as Cachy at all.

Here's the os-release.

cat /etc/os-release NAME="CachyOS Linux" PRETTY_NAME="CachyOS" ID=cachyos ID_LIKE=arch BUILD_ID=rolling ANSI_COLOR="38;2;23;147;209" HOME_URL="https://cachyos.org/" DOCUMENTATION_URL="https://wiki.cachyos.org/" SUPPORT_URL="https://forum.cachyos.org/" BUG_REPORT_URL="https://github.com/cachyos" PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/" LOGO=cachyos

— Reply to this email directly, view it on GitHub[https://github.com/bobafetthotmail/refind-theme-regular/pull/40#issuecomment-1482018756], or unsubscribe[https://github.com/notifications/unsubscribe-auth/APCYDDOCJG5YP556FQQ55P3W5TIR7ANCNFSM6AAAAAAVBL6YVY]. You are receiving this because you authored the thread.[Tracking image][https://github.com/notifications/beacon/APCYDDJM235OXCLFZJPAM7DW5TIR7A5CNFSM6AAAAAAVBL6YV2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSYKXH4I.gif]

bobafetthotmail commented 1 year ago

should be fixed now with https://github.com/bobafetthotmail/refind-theme-regular/commit/99b1681914edbd7f82e757274041de459f217c76 as I have renamed the icons into os_cachyos

I also added a line in the instruction about choosing the right name for the icons by looking at /etc/os-release