bobafetthotmail / refind-theme-regular

http://munlik.deviantart.com/art/rEFInd-theme-512091944
Other
783 stars 76 forks source link

Added bootorder tool and OpenCore logo, updated Windows and NixOS logos #46

Closed Litarvan closed 1 year ago

Litarvan commented 1 year ago

I updated a few logos:

Here is a preview of all these changes: screenshot_1 screenshot_2

bobafetthotmail commented 1 year ago

Hello and thanks for the time to investigate the Windows icon issue. The icons for NixOS and OpenCore are fine. For the Windows icons, I would prefer to keep the older windows icons so people can "choose" them by just renaming the icons (will add a paragraph in the Readme explaining what to do). Can you please rename them to something else like say windows_8 windows_10 instead of deleting them? You can just add a commit with the change on top of the other one, I'll merge everything into one.

As for the netboot icon, from what I have been able to gather by googling, it has nothing to do with netboot.xyz or ipxe so that's a no. Please remove it or replace it with something like this (it's also a svg so you can just take this as a base), where their official icon which has just a black outline has been put inside a light grey background so it's always readable even on a black background and looks more like an icon. netboot xyz1

Litarvan commented 1 year ago

Hello!

You are right for the Windows icons, I thought of that too later. I added back the Windows 8 and Windows 10 icons as os_win8.png alts: os_win8-alt1.png and os_win8-alt2.png) I don't think naming them something like os_win10.png is a good idea, since it will create the same confusion that led to the #44. Since os_win8 is the actual name rEFInd is looking for, naming them as alts of this is probably a good idea, it's a way of telling the user to rename it like this to use it. Tell me if that's ok. I also added back the Microsoft icon as os_windows-alt.png.

For the netboot icon, I was afraid that using the official svg would look odd. But adding a light grey background is a good idea, I replaced the icon. I struggled a bit to find a way to do it properly: I made a square to keep the same proportions as the other icons, and tried to use a shade of grey that was visible on both themes. It looks like this, tell me what you think:

image image

It's not perfect but it works, tell me if you want me to made adjustments. I squashed the commit with the previous one.

bobafetthotmail commented 1 year ago

Ok that's good. Thanks