search

bobafetthotmail / refind-theme-regular

http://munlik.deviantart.com/art/rEFInd-theme-512091944
Other
783 stars 76 forks source link

she-bang changed to fix errors, added an option for config file preservation. #9

Closed joejose97 closed 4 years ago

joejose97 commented 4 years ago

As the original script had #!/bin/sh as she-bang it was throwing errors. So it was changed to bash. The script is actually a bash script. Added an option to preserve a secondary config file that may contain other options changed by the user. Even if the preserved config file contains themeing options, those will be overridden.

bobafetthotmail commented 4 years ago

uhm, you are changing links to download from your fork, I can't merge that. Please adjust them to be from this repository.

Also, remove the credits from the script. It was contributed by other people, not me or Munlik. see the commit history https://github.com/bobafetthotmail/refind-theme-regular/commits/master

joejose97 commented 4 years ago

Sorry about that. I'm new to this. I thought you could change it while merging. It should be okay now.

bobafetthotmail commented 4 years ago

ok merged, thanks

joejose97 commented 4 years ago

The auto install instruction still runs the script through sh. It should be sudo bash -c "$(curl -fsSL https://raw.githubusercontent.com/bobafetthotmail/refind-theme-regular/master/install.sh)" I missed it in the last commit. Should I open a new PR?

bobafetthotmail commented 4 years ago

no, fixed that now, thanks.