search

bobanetwork / boba

Boba Network Monorepo of the Optimism monorepo where Erigon sequencing happens :)
https://boba.network
MIT License
6 stars 8 forks source link

Upstream v1.9.5 #276

Closed boyuan-chen closed 1 week ago

boyuan-chen commented 2 weeks ago

:clipboard: Add associated issues, tickets, docs URL here.

Overview

Describe what your Pull Request is about in a few sentences.

Changes

Describe your changes and implementation choices. More details make PRs easier to review.

Upstream v1.9.5

Testing

Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 77.41047% with 82 lines in your changes missing coverage. Please review.

Project coverage is 66.65%. Comparing base (51d6812) to head (ad331ba).

Files with missing lines Patch % Lines
cannon/mipsevm/program/testutil/mocks.go 46.66% 30 Missing and 2 partials :warning:
cannon/cmd/run.go 0.00% 17 Missing :warning:
cannon/mipsevm/testutil/mips.go 75.51% 11 Missing and 1 partial :warning:
cannon/mipsevm/testutil/evm.go 40.00% 5 Missing and 1 partial :warning:
cannon/mipsevm/multithreaded/mips.go 76.19% 3 Missing and 2 partials :warning:
cannon/mipsevm/exec/mips_instructions.go 97.22% 0 Missing and 4 partials :warning:
cannon/mipsevm/testutil/memory.go 50.00% 2 Missing and 2 partials :warning:
cannon/mipsevm/exec/memory.go 50.00% 0 Missing and 1 partial :warning:
cannon/mipsevm/program/load.go 94.11% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #276 +/- ## =========================================== + Coverage 64.86% 66.65% +1.78% =========================================== Files 54 56 +2 Lines 4460 4666 +206 =========================================== + Hits 2893 3110 +217 + Misses 1391 1384 -7 + Partials 176 172 -4 ``` | [Flag](https://app.codecov.io/gh/bobanetwork/boba/pull/276/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork) | Coverage Δ | | |---|---|---| | [cannon-go-tests](https://app.codecov.io/gh/bobanetwork/boba/pull/276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork) | `?` | | | [cannon-go-tests-32](https://app.codecov.io/gh/bobanetwork/boba/pull/276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork) | `61.88% <55.37%> (?)` | | | [cannon-go-tests-64](https://app.codecov.io/gh/bobanetwork/boba/pull/276/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork) | `54.16% <65.56%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/bobanetwork/boba/pull/276?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork) | Coverage Δ | | |---|---|---| | [cannon/mipsevm/arch/arch32.go](https://app.codecov.io/gh/bobanetwork/boba/pull/276?src=pr&el=tree&filepath=cannon%2Fmipsevm%2Farch%2Farch32.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork#diff-Y2Fubm9uL21pcHNldm0vYXJjaC9hcmNoMzIuZ28=) | `100.00% <ø> (ø)` | | | [cannon/mipsevm/arch/arch64.go](https://app.codecov.io/gh/bobanetwork/boba/pull/276?src=pr&el=tree&filepath=cannon%2Fmipsevm%2Farch%2Farch64.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork#diff-Y2Fubm9uL21pcHNldm0vYXJjaC9hcmNoNjQuZ28=) | `100.00% <ø> (ø)` | | | [cannon/mipsevm/memory/memory.go](https://app.codecov.io/gh/bobanetwork/boba/pull/276?src=pr&el=tree&filepath=cannon%2Fmipsevm%2Fmemory%2Fmemory.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork#diff-Y2Fubm9uL21pcHNldm0vbWVtb3J5L21lbW9yeS5nbw==) | `79.34% <100.00%> (+0.82%)` | :arrow_up: | | [...non/mipsevm/multithreaded/testutil/expectations.go](https://app.codecov.io/gh/bobanetwork/boba/pull/276?src=pr&el=tree&filepath=cannon%2Fmipsevm%2Fmultithreaded%2Ftestutil%2Fexpectations.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork#diff-Y2Fubm9uL21pcHNldm0vbXVsdGl0aHJlYWRlZC90ZXN0dXRpbC9leHBlY3RhdGlvbnMuZ28=) | `100.00% <ø> (+2.59%)` | :arrow_up: | | [cannon/mipsevm/testutil/arch.go](https://app.codecov.io/gh/bobanetwork/boba/pull/276?src=pr&el=tree&filepath=cannon%2Fmipsevm%2Ftestutil%2Farch.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork#diff-Y2Fubm9uL21pcHNldm0vdGVzdHV0aWwvYXJjaC5nbw==) | `60.00% <100.00%> (+3.47%)` | :arrow_up: | | [cannon/mipsevm/testutil/elf.go](https://app.codecov.io/gh/bobanetwork/boba/pull/276?src=pr&el=tree&filepath=cannon%2Fmipsevm%2Ftestutil%2Felf.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork#diff-Y2Fubm9uL21pcHNldm0vdGVzdHV0aWwvZWxmLmdv) | `100.00% <100.00%> (ø)` | | | [cannon/mipsevm/testutil/oracle.go](https://app.codecov.io/gh/bobanetwork/boba/pull/276?src=pr&el=tree&filepath=cannon%2Fmipsevm%2Ftestutil%2Foracle.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork#diff-Y2Fubm9uL21pcHNldm0vdGVzdHV0aWwvb3JhY2xlLmdv) | `71.02% <100.00%> (ø)` | | | [cannon/mipsevm/testutil/state.go](https://app.codecov.io/gh/bobanetwork/boba/pull/276?src=pr&el=tree&filepath=cannon%2Fmipsevm%2Ftestutil%2Fstate.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork#diff-Y2Fubm9uL21pcHNldm0vdGVzdHV0aWwvc3RhdGUuZ28=) | `77.67% <ø> (-0.59%)` | :arrow_down: | | [cannon/mipsevm/testutil/vmtests.go](https://app.codecov.io/gh/bobanetwork/boba/pull/276?src=pr&el=tree&filepath=cannon%2Fmipsevm%2Ftestutil%2Fvmtests.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork#diff-Y2Fubm9uL21pcHNldm0vdGVzdHV0aWwvdm10ZXN0cy5nbw==) | `91.42% <100.00%> (+0.90%)` | :arrow_up: | | [cannon/mipsevm/exec/memory.go](https://app.codecov.io/gh/bobanetwork/boba/pull/276?src=pr&el=tree&filepath=cannon%2Fmipsevm%2Fexec%2Fmemory.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork#diff-Y2Fubm9uL21pcHNldm0vZXhlYy9tZW1vcnkuZ28=) | `80.95% <50.00%> (+0.95%)` | :arrow_up: | | ... and [8 more](https://app.codecov.io/gh/bobanetwork/boba/pull/276?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork) | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/bobanetwork/boba/pull/276/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bobanetwork)
boyuan-chen commented 1 week ago

It wasn't part of this PR, but I noticed that the previous version bump to go-1.22 also needs to be applied to the builder image in https://github.com/bobanetwork/boba/blob/develop/ops-bedrock/Dockerfile.l2-erigon

Ok! I will do it in another PR.