bobanetwork / boba_legacy

Monorepo implementing Boba, a compute layer for Ethereum
https://boba.network
MIT License
62 stars 61 forks source link

[Gateway 2.5] : test release issue reports. #1079

Closed sk-enya closed 1 year ago

sk-enya commented 1 year ago

Issue Type

[x] bug report
[ ] feature request

Current Behavior

Please list down all the issues based on testing of gateway 2.5.

Known Issues.

Findings

cschlauf commented 1 year ago

When switching from Eth to BNB the prompt still advises to switch to Ethereum

If a user switches to a network - then the gateway should switch the UI for them

cschlauf commented 1 year ago
Screenshot 2023-08-02 at 2 10 00 PM

This should say "token" not "amount"

It's already fixed on Token Page

cschlauf commented 1 year ago
Screenshot 2023-08-02 at 2 11 05 PM

this message should come up when someone selects the bridge button

Fix has been sent on : https://github.com/bobanetwork/boba/pull/1084

cschlauf commented 1 year ago

There needs to be a chain select button in the top right corner as per design below.

Screenshot 2023-08-08 at 10 36 43 AM

cschlauf commented 1 year ago

There is no BNB liquidity in the BNB fast bridge so we can not test it

cschlauf commented 1 year ago

Current Blocks 0/64 - double check that it's not hard coded

PD: It's hard coded

cschlauf commented 1 year ago
Screenshot 2023-08-02 at 2 21 06 PM

false positive error message regarding liquidity eth l1 to l2

Fixes has been updated there https://github.com/bobanetwork/boba/pull/1084

cschlauf commented 1 year ago
Screenshot 2023-08-02 at 2 24 46 PM

For testnets this should say "BNB testnet" not "BNB" make sure all of the testnet modals are correct.

cschlauf commented 1 year ago

3rd party bridging options disappear without explanation :

bridges are visible only when connected to ETH mainnet!

cschlauf commented 1 year ago
Screenshot 2023-08-02 at 2 32 11 PM
  1. Boba BNB not labeled appropriately
  2. Logo is missplaced.
cschlauf commented 1 year ago

add the option to import tokens to Metamask after bridging

cschlauf commented 1 year ago

Modals pop up an inappropriate times and tell you to do things that are against user intent.

cschlauf commented 1 year ago

text needs to be updated to reflect that it's only 7 days when withdrawing from l2 to l1 Screenshot 2023-08-02 at 2 39 31 PM

@cschlauf copy has been updated to Although this option is always available, it takes 7 days to receive your funds when withdrawing from L2 to L1

cschlauf commented 1 year ago

X Chain relay fee - seems excessive? 300 Boba to go from Boba L2 to Eth l1

From sourdeep. The cost of relaying messages L2>L1 is generally expensive in terms of gas, and since we bear that cost by running our relayers, this x chain relay fee is a way to compensate. The current fee amount of 300 boba could in some cases even be insufficient in covering the relayers cost. Although, we can technically change this fee to any amount that we want but needs to get approval from business as it determines revenue

That's correct please refer screenshot below and link Screenshot 2023-08-09 at 1 41 25 PM https://bobascan.com/address/0x29F373e4869e69faaeCD3bF747dd1d965328b69f#readProxyContract

cschlauf commented 1 year ago

<img width="261" alt="Screenshot 2023-08-02 at 2 44 48 PM"

Screenshot 2023-08-02 at 2 45 04 PM

src="https://github.com/bobanetwork/boba/assets/121965721/316c9945-94ba-4032-a3d3-a66bace69545"> Discrepancy in balances. Gateway shows no balance. When metamask does have a balance.

cschlauf commented 1 year ago

There should be an emergency swap option.

cschlauf commented 1 year ago
Screenshot 2023-08-02 at 2 49 04 PM

make sure logos are correct

cschlauf commented 1 year ago
Screenshot 2023-08-02 at 2 49 43 PM

Need to show all network. Avax is missing

cschlauf commented 1 year ago

EARN page.

Screenshot 2023-08-02 at 2 51 47 PM
  1. OMG should replace with BOBA
  2. Update the header on earn page

Both issues has been update on https://github.com/bobanetwork/boba/pull/1084

cschlauf commented 1 year ago

Stake page copy needs to be updated

cschlauf commented 1 year ago

On earn page can't connect to Eth page. Only allows you to connect to BNB

cschlauf commented 1 year ago
Screenshot 2023-08-02 at 2 57 06 PM

On light mode there is a black bar

sk-enya commented 1 year ago

Update copy for alert when insufficient pool info. There is not enough liquidity in the fast bridge pool - reduce your amount or use the Classic Bridge

cc @thenursegreg42069

sk-enya commented 1 year ago

Token picker modal should say head as Select Tokens instead of Select network.

Should render only my tokens as default view

This issue is duplicated

Issue fixed: https://github.com/bobanetwork/boba/pull/1084

sk-enya commented 1 year ago

Screenshot 2023-08-05 at 12 03 23 AM

In this case should have option of emergency swap.

Existing snap on wallet page. Screenshot 2023-08-05 at 12 05 33 AM

sk-enya commented 1 year ago

Add token to meta mask option in token selector modal.

sk-enya commented 1 year ago

History says pending even if Tx is Success.

https://etherscan.io/tx/0x61de635513d88751493283fcbfa77691d2ae13739a9a3e4eafb40ce919997c37

sk-enya commented 1 year ago

There should be an emergency swap option.

@cschlauf can you please help me with user flow for showing the emergency swap modal?

sk-enya commented 1 year ago

Modals pop up an inappropriate times and tell you to do things that are against user intent.

unable to reproduce.

sk-enya commented 1 year ago

Consolidating issues remaining:

cschlauf commented 1 year ago

It's in wallet but should also go when a user doesn't have enough boba @thenursegreg42069 can you provide more clarity?

cschlauf commented 1 year ago
Screenshot 2023-08-09 at 7 15 35 PM
cschlauf commented 1 year ago

Modals pop up an inappropriate times and tell you to do things that are against user intent.

unable to reproduce.

we'll have to do a screen recording on the next testing session

InoMurko commented 1 year ago

I will create a new issue with

Consolidating issues remaining:
- [x] implementation of emergency swap https://github.com/bobanetwork/boba/pull/1097
- [ ] On earn page can't connect to Eth page. Only allows you to connect to BNB
- [x] Discrepancy in balances. Gateway shows no balance https://github.com/bobanetwork/boba/pull/1097
- [ ] Modals pop up an inappropriate times and tell you to do things that are against user intent.
- [x] There is no BNB liquidity in the BNB fast bridge so we can not test it
- [ ] When switching from Eth to BNB the prompt still advises to switch to Ethereum
- [ ] If a user switches to a network - then the gateway should switch the UI for them
- [ ] There needs to be a chain select button in the top right corner as per design below.