bobbens / sketch_simplification

Models and code related to sketch simplification of rough sketches.
https://esslab.jp/~ess/research/sketch_master/
Other
726 stars 103 forks source link

Dockerize #7

Open json2d opened 6 years ago

json2d commented 6 years ago

Added support for deploying with Docker, including usage notes.

Make sure to change the repo namespace from json2d to bobbens when merging, in Dockerfile and README.md

bobbens commented 5 years ago

I can't comment on the docker pull request much as I don't use docker, but it is likely that you will have to make the docker image use pytorch 0.4.1 and not latest (see issue #8 )

json2d commented 5 years ago

you're right thanks for the tip

json2d commented 5 years ago

unfortunately there's no 0.4.1 image available

https://hub.docker.com/r/pytorch/pytorch/tags

do you know if 0.4.0 works?

bobbens commented 5 years ago

I assume it would, but someone would have to test it to make sure.