Game crashes on start

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Start Single player game normal or sprint
2. Click either "start #1", "start #2" or "start #3"
3. Doesn't matter if quadra is running in window or fullscreen

Trunk compiled with VS08 on Windows XP SP3.

Trace:

    quadra_debug.exe!std::_Debug_message(const wchar_t * message=0x00535f10,
const wchar_t * file=0x00535c58, unsigned int line=242)  Zeile 24   C++
>   quadra_debug.exe!std::list<Net::Net_receive_cb
*,std::allocator<Net::Net_receive_cb *> >::_Const_iterator<1>::operator++()
 Zeile 242 + 0x14 Bytes C++
    quadra_debug.exe!Net::packetreceived(Net_buf * nb=0x0012cb90, bool
tcp=true)  Zeile 1305 + 0x64 Bytes  C++
    quadra_debug.exe!Net::step(bool loop_only=false)  Zeile 914 C++
    quadra_debug.exe!Net_starter::Net_module::step()  Zeile 46  C++
    quadra_debug.exe!Executor::step()  Zeile 130    C++
    quadra_debug.exe!Overmind::step()  Zeile 72 C++
    quadra_debug.exe!start_game()  Zeile 2314   C++
    quadra_debug.exe!WinMain(HINSTANCE__ * hInstance=0x00400000, HINSTANCE__
* hPrevInstance=0x00000000, char * lpCmdLine=0x00151f2d, int nShowCmd=1) 
Zeile 104   C++
    quadra_debug.exe!__tmainCRTStartup()  Zeile 263 + 0x2c Bytes    C
    quadra_debug.exe!WinMainCRTStartup()  Zeile 182 C
    kernel32.dll!7c817067()     
    [Unten angegebene Rahmen sind möglicherweise nicht korrekt und/oder
fehlen, keine Symbole geladen für kernel32.dll]    

Original issue reported on code.google.com by tino.mie...@gmail.com on 5 Feb 2009 at 7:28

[GoogleCodeExporter]

I'll take a look to see if I can reproduce on Linux (and then valgrind it) or 
Mac OS X.

Original comment by pphaneuf on 6 Feb 2009 at 11:03

• Added labels: Priority-High, Type-Defect

[GoogleCodeExporter]

Issue 99 has been merged into this issue.

Original comment by pphaneuf on 13 Feb 2009 at 1:36

[GoogleCodeExporter]

#0  Net::packetreceived (this=0x8d9800, nb=0xbfffc0f0, tcp=true) at
skelton/common/net.cpp:1306
#1  0x00068f9c in Net::step (this=0x8d9800, loop_only=<value temporarily 
unavailable,
due to optimizations>) at skelton/common/net.cpp:913
#2  0x0006aef4 in Executor::step (this=0x279180) at 
skelton/common/overmind.cpp:127
#3  0x0006a970 in Overmind::step (this=0x9de44) at 
skelton/common/overmind.cpp:71
#4  0x00008510 in start_game () at source/quadra.cpp:2313
#5  0x000701f4 in SDL_main (ARGC=2, ARGV=0xa00d0) at 
skelton/svgalib/main.cpp:141

Original comment by pphaneuf on 15 Feb 2009 at 12:25

• Changed state: Accepted
• Added labels: OpSys-All

[GoogleCodeExporter]

==504== Invalid read of size 4
==504==    at 0x80E6772:
std::_List_const_iterator<Net::Net_receive_cb*>::operator++() (stl_list.h:224)
==504==    by 0x80E1747: Net::packetreceived(Net_buf*, bool) (net.cpp:1305)
==504==    by 0x80E5556: Net::step(bool) (net.cpp:913)
==504==    by 0x80AA1EF: Net_starter::Net_module::step() (net_stuff.cpp:45)
==504==    by 0x80E93C9: Executor::step() (overmind.cpp:127)
==504==    by 0x80E97D1: Overmind::step() (overmind.cpp:71)
==504==    by 0x804E886: start_game() (quadra.cpp:2313)
==504==    by 0x80EFE8E: main (main.cpp:141)
==504==  Address 0x5495340 is 0 bytes inside a block of size 12 free'd
==504==    at 0x40222EC: operator delete(void*) (vg_replace_malloc.c:342)
==504==    by 0x80E716C:
__gnu_cxx::new_allocator<std::_List_node<Net::Net_receive_cb*>
>::deallocate(std::_List_node<Net::Net_receive_cb*>*, unsigned) 
(new_allocator.h:97)
==504==    by 0x80E7191: std::_List_base<Net::Net_receive_cb*,
std::allocator<Net::Net_receive_cb*>
>::_M_put_node(std::_List_node<Net::Net_receive_cb*>*) (stl_list.h:321)
==504==    by 0x80E807C: std::list<Net::Net_receive_cb*,
std::allocator<Net::Net_receive_cb*>
>::_M_erase(std::_List_iterator<Net::Net_receive_cb*>) (stl_list.h:1172)
==504==    by 0x80E80AE: std::list<Net::Net_receive_cb*,
std::allocator<Net::Net_receive_cb*>
>::erase(std::_List_iterator<Net::Net_receive_cb*>) (list.tcc:99)
==504==    by 0x80E1F36: Net::removewatch(unsigned short, Net_callable*) 
(net.cpp:1008)
==504==    by 0x80EAEC0: Exec_ping::net_call(Packet*) (packet.cpp:124)
==504==    by 0x80E1723: Net::packetreceived(Net_buf*, bool) (net.cpp:1309)
==504==    by 0x80E5556: Net::step(bool) (net.cpp:913)
==504==    by 0x80AA1EF: Net_starter::Net_module::step() (net_stuff.cpp:45)
==504==    by 0x80E93C9: Executor::step() (overmind.cpp:127)
==504==    by 0x80E97D1: Overmind::step() (overmind.cpp:71)

Original comment by pphaneuf on 15 Feb 2009 at 12:57

[GoogleCodeExporter]

Valgrind to the rescue, once again. Should be fixed by r719. Can you verify?

Original comment by pphaneuf on 15 Feb 2009 at 1:52

• Changed state: Fixed

[GoogleCodeExporter]

Nice, r719 compiles fine and is playable again.
(VS08,WinXP)

Original comment by tino.mie...@gmail.com on 16 Feb 2009 at 9:03

[GoogleCodeExporter]

Awesome, thanks!

Original comment by pphaneuf on 16 Feb 2009 at 9:13

• Changed state: Verified

[GoogleCodeExporter]

Issue 96 has been merged into this issue.

Original comment by pphaneuf on 20 Feb 2009 at 12:18