bobbiebrown / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

git master branch fails to build on Linux #667

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
./configure; make

What is the expected output? What do you see instead?
The build is expected to complete, but you first get:
src/client/linux/crash_generation/crash_generation_client.cc:40:51: fatal 
error: third_party/lss/linux_syscall_support.h: No such file or directory
compilation terminated.
make: *** [src/client/linux/crash_generation/crash_generation_client.o] Error 1

This is fixed by creating src/third_party/lss and adding 
linux_syscall_support.h from here: 
https://google-coredumper.googlecode.com/svn/trunk/src/linux_syscall_support.h

Then build fails on:
src/client/linux/handler/exception_handler.cc:425:42: error: too many arguments 
to function ‘int sys_prctl(int, long int)’
In file included from ./src/common/memory.h:51:0,
                 from ./src/client/linux/dump_writer_common/thread_info.h:37,
                 from ./src/client/linux/minidump_writer/linux_dumper.h:51,
                 from ./src/client/linux/minidump_writer/minidump_writer.h:41,
                 from ./src/client/linux/handler/exception_handler.h:42,
                 from src/client/linux/handler/exception_handler.cc:66:
./src/third_party/lss/linux_syscall_support.h:2116:1: note: declared here

which can be fixed by replacing instances of sys_prctl by the standard prctl 
call.

After that, the build succeeds, but I didn't check if all worked OK.

What version of the product are you using? On what operating system?
Latest version from master from here: 
https://chromium.googlesource.com/breakpad/breakpad, on commit 
5f520807ca93f0d95a1e72864f574f4ec19f6188

Please provide any additional information below.
Patch attached. Probably a cleaner way to fix all this.

Original issue reported on code.google.com by alex...@gmail.com on 10 Sep 2015 at 12:54

Attachments: