MATLAB version requirements (Re: vecnorm, min(...,'all'))

bobbielf2 / ZetaTrap3D

Locally corrected trapezoidal rule for Laplace and Helmholtz layer potentials on surfaces in 3D

MIT License

4 stars 2 forks source link

MATLAB version requirements (Re: vecnorm, min(...,'all')) #1

Open ahbarnett opened 4 years ago

ahbarnett commented 4 years ago

Hi Bobbie, My attempt to run the test codes failed on Matlab R2017a due to:

missing function vecnorm.m Introduced in R2017b
min(..,'all') https://www.mathworks.com/help/matlab/ref/min.html M = min(A,[],'all') finds the minimum over all elements of A. This syntax is valid for MATLAB® versions R2018b and later. You could replace by min(min(...)) and make this more backward-compatible.

So, it would be great if you list the version requirement, and any Toolboxes needed, in your README.md. Thanks, Alex

ahbarnett commented 4 years ago

I ran the tests in R2020a and they work - very nice.

PS if my BIE3D codes were useful - looks like the double PTR and test geometries were borrowed - you may want to acknowledge that in the preprint...;)

PPS we call the twisted wobbly torus a "cruller" here: https://arxiv.org/abs/1904.00076 https://en.wikipedia.org/wiki/Cruller#/media/File:French-Cruller-Donut.jpg

Cheers, Alex

bobbielf2 commented 4 years ago

Hi Alex, Thanks for testing the code! I just pushed a fix to the compatibility issue, let me know if they don't work. I will update the preprint and mention the "cruller" for sure. Thanks, Bobbie