bobbieltd / xmr-node-proxy

XNP with algorithm and blob type settings + HTTP rigs monitoring (Based on MoneroOcean)
https://semipool.com
9 stars 8 forks source link

quality of life improvements #8

Open untoreh opened 6 years ago

untoreh commented 6 years ago

is it possible to implement these two features?

bobbieltd commented 6 years ago
  1. I don’t understand what you mean. Varrdiff is based on worker’s hashrate. It is the best for worker. If you means that taking proxy hashrate for diff, the diff will be very high (because proxy hashrate is much bigger than seperate worker) and unefficient.
  2. Hot config reload is feasable. What do you suggest to implement this feature (hotkey or httpweb) ? I’ll ask MoneroOcean at first. If he doesn’t implement it, I’ll try to do it myself. Thanks.
untoreh commented 6 years ago
  1. I mean just the starting diff, the diff specified in the listeningPorts field is the starting diff after which the proxy aligns the diff to the miner speed, so for example instead of starting each time from 100, start from the average diff of the proxy, then go up or down as it alreadydoes.
  2. a web request is probably better, also a unix signal would be fine (kill -SIGHUP proxypid)
bobbieltd commented 6 years ago

I guess you should wait for MoneroOcean’s answer. It is quite complicated to code for me. In the mean time, here are my suggestions :

  1. You can set higher diff with listening port.
  2. pm2 restart proxy.

I guess you already know all those stuffs. I write just in case 😂. Sincerely, your requested features are not very useful. It makes proxy more complicated to understand for normal users.

untoreh commented 6 years ago

yes those are not critical features, that's why I called them QOL improvements :)