search

bobbingwide / fizzie

Fizzie theme - a Full Site Editing theme using Gutenberg blocks
9 stars 1 forks source link

Deliver workarounds to Gutenberg issues as PRs and tidy Fizzie when implemented #25

Closed bobbingwide closed 1 year ago

bobbingwide commented 3 years ago

To date I've developed local workarounds for a number of issues found in Gutenberg's experimental Full Site Editing solutions. I summarised the local improvements that I've made so far in #18.

Requirements

In the long term I'd want to see these problems addressed in Gutenberg / WordPress core. When this has been done, there should be no need for the local workaround. This issue is to track issues and PRs as they progress through Gutenberg then to remove the local workaround when it's no longer necessary.

Proposed solution

THIS TABLE IS WELL OUT OF DATE - 2022/01/12

Area Fizzie issue Gutenberg issue Gutenberg PR(s) Merged? Removed from Fizzie
core/template-part #1 https://github.com/WordPress/gutenberg/issues/26010 https://github.com/WordPress/gutenberg/pull/26772
core/post-excerpt mentioned in #18 https://github.com/WordPress/gutenberg/issues/26581 https://github.com/WordPress/gutenberg/pull/26806 ( replaces 26785 ) 9.4
core/query-pagination #18 https://github.com/WordPress/gutenberg/issues/26557 ( pre-existing ) https://github.com/WordPress/gutenberg/pull/26831
core/query-loop #11 https://github.com/WordPress/gutenberg/issues/25377 (pre-existing) https://github.com/WordPress/gutenberg/pull/26825
core/template-part postId https://github.com/bobbingwide/fizzie/issues/1#issuecomment-718100940 https://github.com/WordPress/gutenberg/issues/26734 https://github.com/WordPress/gutenberg/pull/26812
core/template-part wpautop() #20 https://github.com/WordPress/gutenberg/issues/26731 https://github.com/WordPress/gutenberg/pull/26809
core/post-content #7 https://github.com/WordPress/gutenberg/issues/26593 https://github.com/WordPress/gutenberg/pull/26807
core/post-hierarchical-terms #29 https://github.com/WordPress/gutenberg/issues/26851 https://github.com/WordPress/gutenberg/pull/26854 9.4
core/post-content #27 https://github.com/WordPress/gutenberg/issues/26923 https://github.com/WordPress/gutenberg/pull/27012
core/navigation-link #22 site_url part
core/navigation #22 current-menu-item part
bobbingwide commented 2 years ago

For Fizzie v1.0.0 I've commented out the logic that's no longer needed, but not yet removed it. I've also updated the logic so that the remaining overrides are applied when Gutenberg is not activated. This caters for sites which have WordPress 5.9; the first version where Gutenberg is not required for an FSE theme.

bobbingwide commented 1 year ago

Closing this issue. I no longer intend raising PRs against Gutenberg. But look forward to when I no longer feel the need to override block rendering.