bobbingwide / fizzie

Fizzie theme - a Full Site Editing theme using Gutenberg blocks
9 stars 1 forks source link

Adjust Fizzie so that it can be used as a parent theme for Wizzie #69

Closed bobbingwide closed 1 year ago

bobbingwide commented 3 years ago

I've started developing a child theme of Fizzie called Wizzie. This new child theme will be integrated with WooCommerce. Since it's going to be implemented on woocommerce.wp-a2z.org it also needs the functionality of Fizzie, hence the parent / child theme relationship.

There are a couple of changes to Fizzie that will make it easier for Wizzie.

  1. When enqueueing category.css replace API calls prefixed get_template_ with get_stylesheet_. This saves copying this particular stylesheet to the child theme.
  2. Consider removing references to the theme in the template-part blocks.
  3. Improve debug blocks to indicate the source theme.
  4. Eliminate badly formed block tags which display as broken blocks.

See https://github.com/bobbingwide/wizzie/issues/1

bobbingwide commented 3 years ago

There was a side effect 780ba81. When using the Fizzie theme and WooCommerce is activated then the --woocommerce var is defined so the navigation menu colour changes intended for Wizzie are applied in Fizzie. This can be prevented by changing --woocommerce to --wp--preset--color--woo-deep-purple. The replacement value is defined when Wizzie is activated. Fizzie will use the other value.

.wp-block-navigation.wp-block-navigation a,
.wp-block-navigation a {
    border: 1px solid var( --wp--preset--color--woo-deep-purple,  #baba54 );
    margin: 0 auto;
    color: #ffffff;
    text-decoration: none;
    background-color: var( --wp--preset--color--woo-deep-purple, #a2ab3b );
    /* font-size: 13px; */
}

At some time in the future we'll change the hardcoded hex values to a variable name or even be able to eliminate the CSS from the stylesheet.

bobbingwide commented 3 years ago

Another change will fix https://github.com/bobbingwide/wizzie/issues/6. Setting the default font using

 * {
    font-family:  Lato, sans-serif;
 }

overrode the font-family defined for the star rating. Remove this and the star ratings appear correctly. theme.json defines the default font.

bobbingwide commented 1 year ago

delivered in v0.7.0