search

bobbingwide / oik-batch

Batch interface to WordPress
https://www.oik-plugins.com/oik-plugins/oik-batch
GNU General Public License v2.0
0 stars 0 forks source link

Support PHPUnit 8 #38

Closed bobbingwide closed 3 years ago

bobbingwide commented 5 years ago

oik-batch is used to run in situ PHPUnit tests. It uses code from wordpress-develop-tests. Both of these plugins need to support PHPUnit 8. We need to change some code in both these plugins.

See https://github.com/bobbingwide/wordpress-develop-tests/issues/7#issuecomment-539944410

bobbingwide commented 5 years ago

For oik-bwtrace changes are needed in tests/testcase.php and tests/class-bw-unittestcase.php ... and other files.

Also need to resolve:

There were 2 warnings:

1) test_class_git::test_php_sapi_doesnt_change
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

2) test_class_git::test_command
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
bobbingwide commented 5 years ago

And I also get

Configuration: C:\apache\htdocs\wordpress\wp-content\plugins\oik-batch\phpunit.xml.dist

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 11:
  - Element 'testsuite': The attribute 'name' is required but missing.

  Test results may not be as expected.

I'm not the only one who's had this. See https://github.com/sebastianbergmann/php-token-stream/issues/79

bobbingwide commented 3 years ago

Closing this. I've been running PHPUnit 8 for over a year now.