[bw_dash] - Update for WordPress 5.0 and the new editor

bobbingwide / oik-bob-bing-wide

More lazy smart shortcodes

https://www.oik-plugins.com/oik-plugins/oik-bob-bing-wide-more-lazy-smart-shortcodes/

GNU General Public License v2.0

1 stars 0 forks source link

[bw_dash] - Update for WordPress 5.0 and the new editor #26

Closed bobbingwide closed 2 years ago

bobbingwide commented 6 years ago

There may be a new editor in WordPress 5.0 that will use a number of different "dashicons" that are implemented using SVG rather than being part of the dashicons font.

Requirement

To be able to use [bw_dash] to display these icons.
To handle all the icons defined in gutenberg/components/dashicon/index.js
To be able to specify the displayed size.
Drop support for icons which don't actually exist

Future requirement

To use SVG icons in preference to dashicons or genericons
To be able to support an SVG/dashicon block

bobbingwide commented 5 years ago

Some of the SVG icons used for blocks no longer match the original dash icon. If we want to use [bw_dash] to display these the code will need to be updated. And because the SVG is more complex the logic to display the icons will need improving to cater for more than just the <path d= parameter.
First example is the archive icon.

bobbingwide commented 5 years ago

Couple of things.

The SVG for the core blocks are not the same as the original dashicons.
The default size for the core block icons is 24. I originally used 20 but increased it for the core/archive icon.

Proposal

Extend the logic to support icons for core blocks as a separate type.
Treat core/archive as if it were font=core. ( or class=core ? )
Add a new font type of core and include all the icons in the core blocks.

bobbingwide commented 5 years ago

Having created a separate block to display Block icons, I can now undo the changes to the SVG version of the archive icon. We'll keep the size at 24 pixels.

bobbingwide commented 4 years ago

There are probably some new dashicons that we should be able to display

bobbingwide commented 4 years ago

There are probably some new dashicons that we should be able to display

Yes there are. These were not included in v1.34.0 I’ll leave the issue open.

bobbingwide commented 2 years ago

There are probably some new dashicons that we should be able to display

Having reworked the [bw_dash] shortcode to use the new list of SVG's available in WordPress's dash icons, icons and social links there are now over 600 SVG icons that can potentially be displayed. This is in addition to the Block icons!

The logic does not yet support the display of these SVG icons. See also #46

bobbingwide commented 2 years ago

I need to complete the documentation update for the 70 or so new icons in the dashicons set. And mention the 280 or so WordPress icons. Note: This excludes the Social links icons which aren't yet supported by the Icon control.

bobbingwide commented 2 years ago

Closing this now that the Dashicon block supports over 580 SVG icons; some dashicons, others WordPress/Gutenberg icons. Delivered in v2.2.1