Closed bobbingwide closed 5 years ago
bobbingwide
commented
6 years ago Current status - table updated 7 Dec
| Environment | Tests | Failures |
|---|---|---|
| qw/wordpress | 72 | 0 |
| qw/oikcom | 72 | 0 |
| qw/hm | 72 | 0 |
| qw/src | 72 | 0 |
| qw/wpms | 72 | 0 |
| qw/wpms/site-2 | 72 | 0 |
| qw/wpms/phphants | 72 | 0 |
bobbingwide
commented
6 years ago In class oik_remote there are some methods used to determine if an URL is local, and therefore an http request can be performed with SSL_verify turned off.
In CLI processing this test only works when the $_SERVER[‘SERVER_NAME’] is set to ‘localhost’. It doesn’t support WordPress Multisite, where SERVER_NAME is set to the primary domain. E.g. ‘qw’. The code and tests should be updated to support this. The table below documents the expected results. In the table the URL has been reduced to just the domain name. E.g https://qw/wordpress becomes qw.
| URL | remote_IP | server_name | local_ip | local IP? | private IP? | computer? | Local? | |
|---|---|---|---|---|---|---|---|---|
| Qw | 192.168.x.y | localhost | 127.0.0.1 | n | y | y | y | y |
| Qw | 192.168.x.y | qw | 192.168.x.y | y | y | y | y | |
| Localhost | 127.0.0.1 | localhost | 127.0.0.1 | y | n | n | y | |
| Localhost | 127.0.0.1 | qw | 192.168.x.y | y | n | n | y | |
| Q.w | 127.0.0.1 | localhost | 127.0.0.1 | y | n | n | y | |
| Q.w | 127.0.0.1 | qw | 192.168.x.y | y | n | n | y | |
| Example.com | x.y.z.n | localhost | 127.0.0.1 | n | n | n | n | |
| Example.com | x.y.z.n | qw | 192.168.x.y | n | n | n | n | |
| Susan-PC | ? | localhost | 127.0.0.1 | n | y? | n | y - TO BE CHECKED | |
| 127.0.0.1 | 127.0.0.1 | localhost | 127.0.0.1 | y | n | n | y | |
| 127.0.0.1 | 127.0.0.1 | qw | 192.168.x.y | y | n | n | y | |
| 196.168.y.z | 192.168.y.z | localhost | 127.0.0.1 | n | y | n | y | |
| 192.168.y.z | 192.168.y.z | qw | 192.168.x.y | n | y | n | y | |
| X.y.z.n | x.y.z.n | localhost | 127.0.0.1 | n | n | n | n | |
| X.y.z.n | x.y.z.n | qw | 192.168.x.y | n | n | n | n |
is_local_ip test which compares the IP for the remote_host with the IP for the server_name. The local IP test should pass when remote_IP is 127.0.0.1, regardless of the value of the IP for the server_name.bobbingwide
commented
6 years ago Some of the shared library functions have also been updated for PHP 7.2 compatability. The affected shared library files also need to be reconciled.
bobbingwide
commented
6 years ago We should have also added libs\bw_fields.php
This missed change was incorrectly associated with #7 in the latest readme.md
bobbingwide
commented
5 years ago The tests are now running to completion on a different machine called s.b. But only in the /wordpress folder. Other environments need support for the bb_BB language. We now need to reconcile oik-libs with oik v3.3.3. and run the PhpUnit tests in multiple environments. Pre-req is to enable language switching to bb_BB. See https://github.com/bobbingwide/oik-i18n/issues/2 Then we can close this issue and https://github.com/bobbingwide/oik/issues/114
Similar to the work done for environment independence in https://github.com/bobbingwide/oik/issues/9 we need to ensure that the tests for the shared library files which are implemented in the oik-libs repository, are environment independent. Some changes will be necessary to the tests and some to the test data. Environments to be supported are local development environments in qw.
Note: Some of the tests expect other development environments to exist. e.g. qw/oikcom and qw/oikcouk which are used as remote plugin and theme servers. As with the tests for oik, many of the tests assume that the environments contain a certain subset of plugins and themes.