search

bobbingwide / oik-types

oik custom content type manager
http://www.oik-plugins.com/oik-plugins/oik-types/
GNU General Public License v2.0
1 stars 0 forks source link

Should a deregistered CPT or taxonomy continue due to overrides? #18

Open bobbingwide opened 5 years ago

bobbingwide commented 5 years ago

The download post type is registered by Easy-Digital-Downloads. I wanted to clone the content so added the capability using oik-types. Having created blocks for EDD, using oik-loader, I no longer need it to be activated. But when EDD is deactivated, the post type is still visible in the admin area. Should it be?

bobbingwide commented 5 years ago

That’s a good question. This side effect would allow us to avoid the notices produced when WooCommerce is not active.

bobbingwide commented 5 years ago

I changed the post type definitions for two post types and it worked.

WooCommerce scheduled-action - corrected the spelling of the description Easy Digital Downloads - edd_payments - added a description.

bobbingwide commented 3 years ago

Having recently developed oik-unloader I've found another reason for allowing the registration overrides to continue to register CPTs when the original plugins are deactivated. I'll need to try this for sites with WooCommerce where we still need products to be registered in order to get the correct permalinks.