search

bobbingwide / oik

OIK Information Kit
https://www.oik-plugins.com/oik-plugins/oik
GNU General Public License v2.0
2 stars 0 forks source link

Pagination not working in WordPress 4.4 #13

Closed bobbingwide closed 8 years ago

bobbingwide commented 8 years ago

It took me a while to notice, but after upgrading to WordPress 4.4, we realised that pagination was not working properly. The x to y of z information and the paging links were correct, but the listed content being displayed was always from page one.

Explanation

The function _bw_get_posts() which is used when we need the total number of posts was passing the default value for offset, 0. It seems that this should now be ''.

Temporary fix

Change the code in _bw_get_posts() from 'offset' => 0 to 'offset' => '' File oik/includes/bw_posts.inc This fix has been applied to oik-plugins.com

Permanent fix

Publish a new version of the oik base plugin. Rather than issue v2.5.1 we may decide to officially release version v3.0.0.

bobbingwide commented 8 years ago

The problem came about due to a change in WordPress 4.4 for TRAC 34060. I have raised TRAC 35172 since this change broke backward compatibility.

bobbingwide commented 8 years ago

In order to deliver 2.5.1 we need to make oik compatible with oik-bwtrace v2.0.9 and oik-lib.