bobbingwide / thisis

ThisIs ... experimental Full Site Editing theme
GNU General Public License v3.0
1 stars 0 forks source link

Update for Gutenberg 10.7 #32

Open bobbingwide opened 3 years ago

bobbingwide commented 3 years ago

Gutenberg 10.7 is coming soon.

I pulled the source code yesterday and rebuilt it.

I needed to update node.js to a new version. On my Windows machine I found that the easiest way to do this was to downloading v14.7.0 LTS from https://nodejs.org/en/ LTS stands for Long Term Support.

Having activated the newly built version in s.b/wp55/thisis I noticed a few changes on the front end. These need to be investigated, and the changes accounted for. I hope this means I'll have to make changes to my code rather than reporting issues.

Changes detected so far

Front page

bobbingwide commented 3 years ago

Site Logo disappeared again.

image

bobbingwide commented 3 years ago
[21-May-2021 11:03:46 UTC] PHP Fatal error:  Uncaught TypeError: 
Cannot access offset of type string on string in C:\apache\htdocs\wp55\wp-includes\theme.php:1063
Stack trace:
#0 C:\apache\htdocs\wp55\wp-includes\nav-menu.php(1170): set_theme_mod('nav_menu_locati...', Array)
#1 C:\apache\htdocs\wp55\wp-includes\class-wp-hook.php(294): _wp_menus_changed('Twenty Twenty-O...')
#2 C:\apache\htdocs\wp55\wp-includes\class-wp-hook.php(316): WP_Hook->apply_filters('', Array)
#3 C:\apache\htdocs\wp55\wp-includes\plugin.php(484): WP_Hook->do_action(Array)
#4 C:\apache\htdocs\wp55\wp-includes\theme.php(3302): do_action('after_switch_th...', 'Twenty Twenty-O...', Object(WP_Theme))
#5 C:\apache\htdocs\wp55\wp-includes\class-wp-hook.php(292): check_theme_switched('')
#6 C:\apache\htdocs\wp55\wp-includes\class-wp-hook.php(316): WP_Hook->apply_filters(NULL, Array)
#7 C:\apache\htdocs\wp55\wp-includes\plugin.php(484): WP_Hook->do_action(Array)
#8 C:\apache\htdocs\wp55\wp-settings.php(560): do_action('init')
#9 C:\apache\htdocs\wp55\wp-config.php(111): require_once('C:\\apache\\htdoc...')
#10 C:\apache\htdocs\wp55\wp-load.php(37): require_once('C:\\apache\\htdoc...')
#11 C:\apache\htdocs\wp55\wp-admin\admin.php(34): require_once('C:\\apache\\htdoc...')
#12 C:\apache\htdocs\wp55\wp-admin\themes.php(10): require_once('C:\\apache\\htdoc...')
#13 {main}
  thrown in C:\apache\htdocs\wp55\wp-includes\theme.php on line 1063
bobbingwide commented 3 years ago

While the main site is broken I tried on s.b/wp55/universal with TT1 blocks. The response to the request initiated when adding the Site Logo block is image

bobbingwide commented 3 years ago

With 10.6.0 it's different. image

aristath commented 3 years ago

Found the problem with the site-logo block, I'll be submitting a PR in a few minutes.

aristath commented 3 years ago

PR in https://github.com/WordPress/gutenberg/pull/32092

bobbingwide commented 3 years ago

Now my site's completely broken with a Fatal error

I resolved this problem by deleting the empty theme_mods_thisis option from the wp_options table.

bobbingwide commented 3 years ago

Latest posts section is not shown in 3 columns

It would appear that the layout attribute for the Query block has been renamed to displayLayout to take into account the layout option that's been added to negate the need to wrap it in a Group block. See https://github.com/wordpress/gutenberg/pull/31833

The new version of the latest-posts.html template part now has both attributes. Both appear to have the same values.... {"type":"flex","columns":3}.

...
<!-- wp:query {"queryId":7,"query":{"perPage":3,"pages":0,"offset":0,"postType":"post","categoryIds":[],"tagIds":[],"order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"exclude","inherit":false},
"displayLayout":{"type":"flex","columns":3},"layout":{"type":"flex","columns":3}} -->
<div class="wp-block-query">
...
bobbingwide commented 3 years ago

Both appear to have the same values.... {"type":"flex","columns":3}.

This was because I hadn't touched the Inherit default layout toggle in the Layout pane. Toggling it off and on altered the attribute values.

<!-- wp:query {"queryId":7,"query":{"perPage":3,"pages":0,"offset":0,"postType":"post","categoryIds":[],"tagIds":[],"order":"asc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"exclude","inherit":false},
"displayLayout":{"type":"flex","columns":3},"layout":{"inherit":true}} -->
<div class="wp-block-query">
bobbingwide commented 3 years ago

I imagine I'll have to check all uses of the query block. Note also that I'd previously got away with not having a div class="wp-block-query"> start and end tag.

bobbingwide commented 3 years ago

PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in C:\apache\htdocs\wp55\wp-includes\theme.php:1063

This problem also occurred on blocks.wp.a2z as I was trying to get Fizzie to work with Gutenberg 10.7.1. Deactivating Gutenberg does not resolve the problem. Assume the problem resolution will involve deleting the empty theme_mods_fizzie option from the wp_options table. Note: There was also an entry with option_name theme_mods._

Deleting these options did not resolve the problem. I needed to visit Network Admin themes, where I discovered only one theme was network activated. Then visiting https://blocks.wp.a2z/wp-admin/themes.php I saw the message The active theme is broken. Reverting to the default theme. The active theme was not set. image

bobbingwide commented 3 years ago

The Page List block in the sidebar is only showing the top level pages, and the ordering is still not good enough.

Opened https://github.com/WordPress/gutenberg/issues/32379 for the first part. The ordering is already being addressed as https://github.com/WordPress/gutenberg/issues/31382