bobbingwide / thisis

ThisIs ... experimental Full Site Editing theme
GNU General Public License v3.0
1 stars 0 forks source link

Update for Gutenberg 10.9.0 #33

Open bobbingwide opened 3 years ago

bobbingwide commented 3 years ago

In Gutenberg 10.9.0 the wp:query-loop block has been renamed to wp:post-template. The Gutenberg code has been changed to cater for existing Query Loop blocks. But ThisIs implements a Query Loop override to support order by rand.

This may or may not explain other problems that I've noted after updating to 10.9.0

  1. On front-page.html the latest-posts.html template part is showing a link to the home page, not 3 links to the most recent posts.

image

  1. The Site Logo block crashed in the Site Editor. image

Note: The first two messages are from oik-blocks - oik-css block is not being registered correctly - oik-blocks uses the old registration method. Time to update eh?

bobbingwide commented 3 years ago
  1. On front-page.html the latest-posts.html template part is showing a link to the home page, not 3 links to the most recent posts.

Changing the code to use wp:post-template instead of wp:query-loop resolves the problem.

Comments:

bobbingwide commented 3 years ago

When attempting to resolve the Site Logo problem I ended up with a logo size with a non-integer width

<!-- wp:site-logo {"width":319.090909090909} /--></div>

In the original header.html template part the width was 192. But appeared as 193 in the custom version of the header.html template part. The 09 recurring appeared when I tried to reduce the number from 193 to 192.

bobbingwide commented 3 years ago

The “Cannot read property: limitExceeded” message had already been raised as an Issue. I added my comment https://github.com/wordpress/gutenberg/issues/32939

bobbingwide commented 3 years ago

I’ll have to change the query-loop override logic to work against post-template.