bobbingwide / written

An experimental FSE theme to replace Genesis-hm
GNU General Public License v3.0
0 stars 0 forks source link

Develop the Written theme to replace Genesis-HM on herbmiller.me #1

Closed bobbingwide closed 2 years ago

bobbingwide commented 3 years ago

I started developing the Genesis child theme genesis-hm in November 2015. It replaced the Artisteer based theme that I'd been using since 2012.

I very recently wrote a short poem entitled "My Favourite Theme". It's going to be published on/around the 12th July. The last verse is.

So I think you'll agree,
it's a pretty safe bet
that my favourite theme...

Well, it's not written yet! 

I knew it wouldn't be long before I replaced another Genesis child theme with an FSE theme.
I've decided to call this new theme Written.

I've made the assumption that sometime in the future "Written" may become my favourite theme, if only for a fleeting moment. Then either the last line of the poem will have to change, or I'll have to write an addendum.

I now have my favourite, 
I think I am smitten.
I didn't have a while ago,
but, right now, it's "Written".

Requirements

Implementation plan

bobbingwide commented 3 years ago

image

Proposed solution

bobbingwide commented 3 years ago

image

bobbingwide commented 3 years ago

I've been struggling to redevelop the header just using Global Styles and theme.json.

There's also the fact that in the original theme the following CSS is being used.

html {
    font-size: 62.5%; /* 10px browser default */
}

I have to allow for this when setting fontSizes using rem; so 62.5% of 4.1 is 2.25.

Then there's the question of removing the text decoration on the site title.

bobbingwide commented 3 years ago

The metadates.html template part isn't quite how it was in genesis-hm.

image

image

  1. The Categories and Tags lines need prefixes
  2. The Tags separator is a vertical bar rather than a comma
  3. There's no | in the metadates line
  4. I don't know how to style the is-style-griddled to make it left justified
  5. The horizontal separators are the wrong colour and width
bobbingwide commented 3 years ago

Try to do as much of the CSS using Global Styles

During the Hallway Hangout I mentioned some of the problems I had with attempting to use Global Styles in theme.json to do all the styling. It was explained that the idea of theme.json is to define some settings, bit that style.css and other style files would be needed to implement some of the CSS required by the theme.

The challenge is knowing when to use theme.json and when to use CSS.

I've had to implement CSS solutions using is-style- prefixed CSS class names for a number of components. For metadates.html I used display: grid. For the Categories and Tags parts I think CSS flexbox is better. I think I'll be changing metdates to display: flex as well.

bobbingwide commented 3 years ago

It's not possible using theme.json or Global Styles to style the query pagination to be anything like what I had in genesis-hm.

image

image

and what you see in the Site Editor is different from the front end

image

bobbingwide commented 2 years ago

written v0.2.1 is now installed on herbmiller.me I may not have implemented all of the Proposed solution. Well not much at all really...

Proposed solution What I actually did
Header unchanged menu isn't styled as before
Colour palette and background colours unchanged Similar except for sidebar
Sidebar "widgets" unchanged Yes but odd even background not implemented
Consider changing the posts display to show a 2 column grid with shorter excerpts Not done
Which may mean increasing the width and wide width Not done

Closing anyway