Implement extra properties from json-logging-py

[uda]

Addresses feature request #77

Taken from: https://github.com/sebest/json-logging-py/blob/master/jsonlogging.py#L40 Original work by Sebastien Estienne sebastien.estienne@gmail.com Distributed under the MIT license

[bobbui]

thanks for your contribution, there is one test is failing, can u take a look

[alexhafner]

basestring is a Python 2 type, in Python 3 there is only str. The code from json-logging will need to be updated to Python 3.

[bobbui]

ideally the this module is built to support both py2 and py3 . I see this

if sys.version_info < (3, 0):
    EASY_TYPES = (basestring, bool, dict, float, int, list, type(None))
else:
    RECORD_ATTR_SKIP_LIST.append('stack_info')
    EASY_TYPES = (str, bool, dict, float, int, list, type(None))

Isnt it supposed to be working for both py2 and py3

[alexhafner]

Ah, didn't see that you still support Python 2, as the test matrix is only targeting 3.7 to 3.9

In this case flake8 could be instructed to disable the check for this specific line, ie

if sys.version_info < (3, 0):
    EASY_TYPES = (basestring, bool, dict, float, int, list, type(None)) # noqa: F821
else:
    RECORD_ATTR_SKIP_LIST.append('stack_info')
    EASY_TYPES = (str, bool, dict, float, int, list, type(None))

[bobbui]

@uda Can u add suggested flake8 fix to get it passed

[uda]

Yeah, I can remove all Python 2 BC code or put comments to fix the flake8 test

[bobbui]

Yeah, I can remove all Python 2 BC code or put comments to fix the flake8 test

flake8 would be great

[uda]

I added a fix for the basestring definition in python 3, I've seen it in another library with backwards compatibility and flake8 tests where they didn't want to simply ignore F821. But when I run the second flake8 test it failed, but we'll see how it performs on github's pipeline

[bobbui]

looking good

[bobbui]

released https://pypi.org/project/json-logging/1.4.1rc0/