Issue457: Fractional Scaling on Windows

[ptorngren]

Add support for FPAPI: Add new class SwingUtils with methods for leveraging the FPAPI

Modify concerned classes and methods to call SwingUtils and use Rectangle2D and float/double variables instead of Rectangle and integers:

• DefaultTokenPainter.paintBackground()
• RSyntaxUtilities.getLineWidthUpTo()
• SyntaxView: tabBase, tabSize, clipStart, clipEnd, .calculateLongestLine(), lineToRect(), damageLineRange(), modelToView(), nextTabStop(), paint()
• Token.listOffsetToView()
• TokenImpl: getListOffset(), getWidthUpTo(), listOffsetToView()
• VisibleWhitespaceTokenPainter()
• WrappedSyntaxView.modelToView()

Layout/painter changes:

• SyntaxViiew.nextTabStop(): Add offset for tabs to avoid losing tabs that occur on the same pixel as the preceding character end
• ConfigurableCaret: use Rectangle2D and floats/doubles, primarily to avoid double lines on thick vertical line style
• Add RSyntaxTextArea.onGraphicsChange() to let owner refresh font metrics when graphic properties change
• DefaultTokenPainter: Fix tab lines by offsetting the line location slightly
• SwingUtils.drawChars(): Use TextLayout for very long lines or containing complex characters (inspired by SwingUtilities2)

Adapt to Java 11: Replace calls to deprecated elements with corresponding elements for Java 9 or later Rectangles and bounds:

• add SwingUtils.getBounds() to wrap calls to modelToView2D(pos).getBounds() in a null-safe way
• replace calls to JTextComponent.modelToView(int pos) with calls to SwingUtils.getBounds(JTextComponent c, int pos)
• replace calls to JTextComponent.viewToModel(Point p) with calls to JTextComponent.viewToModel2D(Point2D p)

Events:

• replace calls to InputEvent.getModifiers() with calls to MouseEvent.getModifiersEx()
• replace calls to Toolkit.getMenuShortcutKeyMask() Toolkit.getMenuShortcutKeyMaskEx()
• replace references to Event.META_MASK with InputEvent.META_DOWN_MASK
• replace references to Event.CTRL_MASK with InputEvent.CTRL_DOWN_MASK
• replace references to MouseEvent.BUTTON1_MASK with MouseEvent.BUTTON1_DOWN_MASK Not modified:
• SyntaxScheme calls deprecated XMLReaderFactory.createXMLReader() which should be replaced with SaxParserFactory

Also modified the Demo Root Pane:

• add a text example
• show a larger screen centered on monitor
• add a font selector
• add menu option to make whitespace visible

[bobbylight]

@ptorngren - I'm finally looking at this, thank you! I started down this path myself but it's a very large task and I'm duplicating effort here.

Can you rebase this PR against the java-11 branch? All it does so far is update the build to use Java 11. After that, if things look good, can we squash and merge?

My plan is then to release a 4.0.0-SNAPSHOT release to Sonatype while I do a bit more code modernization for Java 11, bump checkstyle, etc.

[ptorngren]

Hi,

Will do asap, but not immediately since we’re shipping a major release “as we speak”. Hope to get around to this in a matter of weeks.

Hälsningar/Regards

Peer Törngren p2r software AB (p2r.se)

------ Original Message ------ From "bobbylight" @.> To "bobbylight/RSyntaxTextArea" @.> Cc "Peer Törngren" @.>; "Mention" @.> Date 2024-11-19 13:57:17 Subject Re: [bobbylight/RSyntaxTextArea] Issue457: Fractional Scaling on Windows (PR #524)

@ptorngren https://github.com/ptorngren - I'm finally looking at this, thank you! I started down this path myself but it's a very large task and I'm duplicating effort here.

Can you rebase this PR against the java-11 branch? All it does so far is update the build to use Java 11. After that, if things look good, can we squash and merge?

My plan is then to release a 4.0.0-SNAPSHOT release to Sonatype while I do a bit more code modernization for Java 11, bump checkstyle, etc.

— Reply to this email directly, view it on GitHub https://github.com/bobbylight/RSyntaxTextArea/pull/524#issuecomment-2485645804, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJDCYSZPHGUGM4RWMOLAHO32BMYS3AVCNFSM6AAAAABSCBSNKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBVGY2DKOBQGQ. You are receiving this because you were mentioned.Message ID: @.***>