search

bobbylight / RSyntaxTextArea

A syntax highlighting, code folding text editor for Java Swing applications.
BSD 3-Clause "New" or "Revised" License
1.1k stars 258 forks source link

Unnecessary Print #561

Closed SamKry closed 1 month ago

SamKry commented 2 months ago

Description Since v3.5.0 there is a System.out which is called on every search next request. Is this really necessary or a leftover from testing new code?

Steps to Reproduce Specific steps to reproduce the behavior:

  1. Open a find dialog and search for sth.

Expected behavior No Print.

Actual behavior Print

Screenshots image

Remove this line.

SamKry commented 2 months ago

I just saw that you already deleted the SysOut in the SmartHighlightPainter. Can you please release a new Version with the Fix? Thx

remcopoelstra commented 2 months ago

I think something may have gone wrong, I just updated to 3.5.1 and noticed the sysout messages, looking at the commit history I see it was indeed removed but also added back.

The ligatures support is looking very nice by the way!

eybisi commented 1 month ago

https://github.com/bobbylight/RSyntaxTextArea/commit/bfc9cc93019eb1da0253ec054a8f863b2b1a71df adds back sysout messages. Is this intended ? @bobbylight

hshafie commented 1 month ago

May be not related but close. Upgraded to 3.5.1 and when I select some text, I get: ... SmartHighlightPainter: rendering: 3662 - 3667 printed on the console, over and over, until I deselect the text.

bobbylight commented 1 month ago

argh, not sure how this happened! I'll fix this in a quick 3.5.2. Thanks folks

bobbylight commented 1 month ago

Fixed (for real this time, hopefully) via #566 which will be in 3.5.2.

SamKry commented 4 weeks ago

Hey When do you plan to release the new version with the fix? Would really appreciate it :)