search

bobbynarvy / highway

Simple routing for PHP. PSR-7 and PSR-15 compatible.
MIT License
7 stars 1 forks source link

Allow dash and update dependencies #3

Closed fizk closed 4 years ago

fizk commented 4 years ago

Hey. I really like your Router implementation and have been using it in a few projects of mine.

There were a few things I needed to update and was wondering if you would like to update the source-code

What

Allow values in a route to contain - (dash)

The path /some/{id} doesn't allow {id} to contain dashes. This means that IDs can't be UUIDs. So while this is valid: /some/1, this is not: /some/1-1

Zend deprecated

The Zend namespace has been deprecated in favour of Laminas.

How

To allow for - is easy, just update the Regex in the match method

To remove Zend dependency. For the tests, as they use the Zend library, this was replaced with Laminas equivalent classes. For the code, there was only one Zend class used, which can be replaced by custom class ResourceNotFoundResponse

bobbynarvy commented 4 years ago

Hi there, thanks a lot for your contributions. Sorry for the late action on this. I haven't really been active here.

There are no objections from my side so I'll merge it. I'll have to update composer.json though so that it reflects this repo's name instead of your fork's.

Obviously, it's been two years since I worked on this project and it was first and foremost a learning project for myself (as all of my project are tbh). I haven't worked with PHP for a while and I'm not really planning on updating this project. I wanted to know whether you're planning to do anything serious with it.

Thanks again!