Doesn't work in Bolt 3.3

bobdenotter / seo

Bolt SEO extension

https://bobdenotter.github.io/seo/

MIT License

49 stars 34 forks source link

Doesn't work in Bolt 3.3 #49

Closed siada closed 7 years ago

siada commented 7 years ago

This commit: https://github.com/bolt/bolt/commit/1807ffe432ca5e01f24f38ae0504e5464b6d8a0b causes this extension to no longer work with 3.3-beta (as of beta-3 an onwards) as the SeoField implements FieldInterface not FieldTypeInterface

bobdenotter commented 7 years ago

I am out of town until July 4th, so I won't be able to take a look in the meantime. I'll do so, when I get back, unless somebody makes a PR before that time.

siada commented 7 years ago

I've created a PR to move SeoField to FieldTypeBase, which fixes this for bolt 3.3 but I'm unsure if this will break for below 3.3?

peterboorsma commented 7 years ago

Same problem here. @siada Your fix works on my 3.3.0 beta installs. A quick test with Bolt 3.2.11 was also positive.

bobdenotter commented 7 years ago

@peter which site is this? I used 1.0.1 on Vlieland yesterday, and I was certain it worked.