bobderrico80 / rhythm-randomizer-v2

Version 2 of the Rhythm Randomizer project
https://www.rhythmrandomizer.com
GNU General Public License v3.0
7 stars 2 forks source link

Parse time signature share string character as hexadecimal instead of decimal #51

Closed bobderrico80 closed 3 years ago

bobderrico80 commented 3 years ago

This will be necessary to support sharing the additional time signatures to be added in #22. Index 2 in the share string is currently storing the time signature. This is parsed as a decimal number, allowing only for 10 time signatures. Prior to this change, all 10 indexes are in use (2/4, 3/4, 4/4, C, 5/4, 6/4, 7/4, 6/8, 9/8, 12/8). To support sharing 2/2, 3/2, 4/2, and cut-time, this character should be parsed as a hexadecimal. This will allow the existing share string format to be used while also support the additional time signatures.

Scope