search

boberfly / GafferCycles

Cycles for Gaffer
BSD 3-Clause "New" or "Revised" License
85 stars 10 forks source link

BVH creation segfaults sometimes #13

Closed boberfly closed 5 years ago

boberfly commented 5 years ago

This is pretty major and it has cropped up recently.

The segfault happens here: https://github.com/boberfly/cycles/blob/39b5b8d34c8dec7e98959e86b602ab8eaed21ea9/src/render/mesh.cpp#L1086

boberfly commented 5 years ago

This is a weird bug which mysteriously went away when I updated to the latest Cycles, so it might've been an internal bug of Cycles. I'll keep this open until I'm confident that it's fixed, but suspiciously there was a memset call for something else which cleared out the params struct in the scene object which was causing the wrong parameters to be passed to BVH creation.

boberfly commented 5 years ago

https://github.com/boberfly/GafferCycles/commit/3817d3d05a5492fdac4ad131398d8ab57b1b2275

Wow, I am glad this is fixed.....