Curve rendering fixes - Githubissues

boberfly / GafferCycles

Cycles for Gaffer

BSD 3-Clause "New" or "Revised" License

85 stars 10 forks source link

Curve rendering fixes #23

Closed murraystevenson closed 5 years ago

murraystevenson commented 5 years ago

Hey Alex,

I gave curve rendering a try and ran into a few issues, so I took a stab at fixing them. Let me know what you think.

Supports constant width
Cycles expects radius rather than width
cmesh->add_curve expects to receive the index of the first key of the curve, rather than the curve index

boberfly commented 5 years ago

Yay my first PR!

I haven't got any test data to verify but I am sure you've got something that you're testing with and you're getting the desired outcome for curves with this fix?

Very cool, cheers!