boberfly / GafferCycles

Cycles for Gaffer
BSD 3-Clause "New" or "Revised" License
85 stars 10 forks source link

cyclesOption node is empty #34

Closed acorsei closed 4 years ago

acorsei commented 4 years ago

creating a cycleOption node results in an empty node. see bellow screencapture and console output. thanks

Screenshot_gaffer_20191216200855 Traceback (most recent call last): File "/media/Media_B/repo_lnx/gaffer-0.55.1.0-linux/python/GafferUI/Widget.py", line 937, in eventFilter self.showHide( qObject, qEvent ) File "/media/Media_B/repo_lnx/gaffer-0.55.1.0-linux/python/GafferUI/Widget.py", line 1004, in showHide widget._visibilityChangedSignal( widget ) IECore.Exception: Traceback (most recent call last): File "/media/Media_B/repo_lnx/gaffer-0.55.1.0-linux/python/GafferUI/LazyMethod.py", line 140, in visibilityChanged cls.doPendingCalls( widget, method ) File "/media/Media_B/repo_lnx/gaffer-0.55.1.0-linux/python/GafferUI/LazyMethod.py", line 174, in doPendingCalls method( widget, *pendingCall.args, **pendingCall.kw ) File "/media/Media_B/repo_lnx/gaffer-0.55.1.0-linux/python/GafferUI/PlugLayout.py", line 250, in updateLazily self.update() File "/media/Media_B/repo_lnx/gaffer-0.55.1.0-linux/python/GafferUI/PlugLayout.py", line 263, in update self.updateSummariesWalk( self.rootSection ) File "/media/Media_B/repo_lnx/gaffer-0.55.1.0-linux/python/GafferUI/PlugLayout.py", line 363, in updateSummariesWalk self.updateSummariesWalk( subsection ) File "/media/Media_B/repo_lnx/gaffer-0.55.1.0-linux/python/GafferUI/PlugLayout.py", line 360, in updateSummariesWalk section.summary = self.metadataValue( self.parent, self.layoutName + ":section:" + section.fullName + ":summary" ) or "" File "/media/Media_B/repo_lnx/gaffer-0.55.1.0-linux/python/GafferUI/PlugLayout.py", line 422, in metadataValue return Gaffer.Metadata.value( plugOrNode, name ) File "/home/acorsei/applications/gafferCycles/python/GafferCyclesUI/CyclesOptionsUI.py", line 138, in samplingSummary if plug["useAdaptiveSampling"]["enabled"].getValue() : KeyError: "'useAdaptiveSampling' is not a child of 'options'"

boberfly commented 4 years ago

Hey @acorsei

Is this with the experimental build I just published? It's pretty raw but cheers for the heads-up I know what it is to fix it, I'll make a new build when I get home tonight.

Cheers!

acorsei commented 4 years ago

Hi @boberfly Confirmed, it’s the experimental build. No worries, great job and will let you know if hit in others matters. Amazing and thanks a lot, Regards

boberfly commented 4 years ago

Hey @acorsei

I've fixed this build here: https://github.com/boberfly/GafferCycles/releases/tag/0.12.0-experimental

Cheers

acorsei commented 4 years ago

Thanks @boberfly that fix the matter.