Closed chaitan94 closed 4 years ago
Hi thanks for the PR, I do not have my Mac with me at this moment. I will review this later. Will keep you posted on what I may find.
Okay I got this working -- I replaced std::optional
with a customized tl::optimal
(recommended by tomlplusplus on their webpage) and this seems now working. @chaitan94 @EpicWink do you see any potential issue going forward with this?
Can't really say for sure as I haven't had much experience with C++17 features yet. But I think we should be good as long as our tests run on all platforms.
Try building the package in a manylinux1 Docker image, if you're particularly worried. Otherwise I agree: if it builds in Mac CI, then there should be no issues
Cool thanks I will get this merged then.
Currently, this fails with the following error:
This seems to be because of the C++17 feature
optional
behaving differently on MacOS.