bobfang1992 / pytomlpp

A python wrapper for tomlplusplus
https://bobfang1992.github.io/pytomlpp/pytomlpp.html
MIT License
86 stars 10 forks source link

Build wheels for Windows (64 bit, non-pypy) #16

Closed chaitan94 closed 4 years ago

chaitan94 commented 4 years ago

It seems the one issue was that the name 'timezone' is taken by the MSVC's preprocessor. Renaming the variable which was using this name turned out to solve this issue.

However, there seems to be another issue while running tests which looks like a unicode issue:

>       assert_matches_json(table, table_json)

D:\a\pytomlpp\pytomlpp\tests\python-tests\test_api.py:87: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
D:\a\pytomlpp\pytomlpp\tests\python-tests\test_api.py:69: in assert_matches_json
    assert_matches_json(yaml_obj[key], json_obj[key])
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

yaml_obj = '\u03b4', json_obj = {'type': 'string', 'value': '\xce\xb4'}

But wheel seems to be being built as of now regardless of this issue.

chaitan94 commented 4 years ago

This is working smoothly after https://github.com/bobfang1992/pytomlpp/pull/15

chaitan94 commented 4 years ago

@bobfang1992 This should be good to merge

bobfang1992 commented 4 years ago

Thanks!