search

bobfang1992 / pytomlpp

A python wrapper for tomlplusplus
https://bobfang1992.github.io/pytomlpp/pytomlpp.html
MIT License
86 stars 10 forks source link

Build using setuptools natively #2

Closed EpicWink closed 4 years ago

EpicWink commented 4 years ago

Now simply install with pip install ..

This will allow for simple wheel building with python setup.py bdist_wheel or pip wheel . --no-deps. This is required for PyPI distribution.

Note that the bundled (Git module) PyBind11 isn't used: rather, pip gets is during the build process. This means people with only the source-distribution (created by python setup.py sdist) can install it without any pre-requisites.

bobfang1992 commented 4 years ago

First, I want to thank you for contributing! This is what I need! As you can see this is my first open-source project and this is exactly where I needed help as I am not an expert on Python packaging etc.

Second, for this commit, can we include a change to delete the local pybind11 subrepo then since it seems that it will be no longer needed.

Thanks!

EpicWink commented 4 years ago

Will do. I've enabled maintainer edits, so you're able to make changes and push them to my branch

However, removing PyBind11 will break the cmake test build. I think this is fine as we only need to test the Python code, which is done via PyTest anyway

bobfang1992 commented 4 years ago

Thanks a lot! @EpicWink

bobfang1992 commented 4 years ago

Hi sorry, given we have #4 coming let's just keep the pybind11 submodule for now and I will merge this.