search

bobfang1992 / pytomlpp

A python wrapper for tomlplusplus
https://bobfang1992.github.io/pytomlpp/pytomlpp.html
MIT License
86 stars 10 forks source link

[toml::date_time] Add custom type caster #28

Closed chaitan94 closed 4 years ago

chaitan94 commented 4 years ago

In continuation to https://github.com/bobfang1992/pytomlpp/pull/26 and https://github.com/bobfang1992/pytomlpp/pull/27, which added custom type caster for toml::date and toml::time, this PR adds similar support for toml::date_time

marzer commented 4 years ago

I just saw in your previous commit that my #pragma region blocks are causing warning spam in GCC, and apparently the warning isn't being suppressed properly due to a known GCC bug. I'll refactor toml.hpp to get rid of that noise.

bobfang1992 commented 4 years ago

LGTM. would love to see some unit testing on date/time/datetime/datetime with tz etc. This is the part where things could go wrong I feel. I will merge this now.