Closed ioistired closed 3 years ago
Hm… this build failure is unrelated to my changes. The job I added succeeded, in fact.
ok I can take a look during the weekend probably.
Seems Py3.5 is deprecated and the issue is somehow related to Py3.5. Do you mind helping me to change the CIBW_SKIP variable to ignore build for Py3.5? Thanks!
From
CIBW_SKIP: cp27-* pp* *-win32
change to
CIBW_SKIP: cp27-* pp* *-win32 cp35-*
Hi I fixed this can you rebase and then you should be fine?
ping @ioistired
Rebased
That's odd, I just rebased on top of master, which includes commit 970d1bcee535cc7f34f04b513c64e379e976d6fa which upgrades toml++
What would you like me to do?
@ioistired I believe this should be sufficient:
cd third_party/tomlplusplus && git checkout d962c6ccc1241a3906642c071d27b11a031471b4
How's that?
Yup, looking good.
One question, so if I merge this and then I do pip install pytomlpp
what do I get? The binary version or the source dist? What controls the behaviour? Thanks! @ioistired
What controls the behavior?
Whether there's a binary distribution available for your platform. Pip prefers binary distributions by default. If there's no wheel for your platform it will download and try to compile the source.
What controls the behavior?
Whether there's a binary distribution available for your platform. Pip prefers binary distributions by default. If there's no wheel for your platform it will download and try to compile the source.
Cool, this one needs a fairly new compiler toochain so I am not sure how many python guys will have that installed. But anyway this is a good addition and I will merge it now.
Updates the GitHub Actions: adds a job to build and upload an sdist artifact.
fixes #47