search

bobfang1992 / pytomlpp

A python wrapper for tomlplusplus
https://bobfang1992.github.io/pytomlpp/pytomlpp.html
MIT License
86 stars 11 forks source link

Build and upload source dists (fixes #47) #50

Closed ioistired closed 3 years ago

ioistired commented 3 years ago

Updates the GitHub Actions: adds a job to build and upload an sdist artifact.

fixes #47

ioistired commented 3 years ago

Hm… this build failure is unrelated to my changes. The job I added succeeded, in fact.

bobfang1992 commented 3 years ago

ok I can take a look during the weekend probably.

bobfang1992 commented 3 years ago

Seems Py3.5 is deprecated and the issue is somehow related to Py3.5. Do you mind helping me to change the CIBW_SKIP variable to ignore build for Py3.5? Thanks!

bobfang1992 commented 3 years ago

From

       CIBW_SKIP: cp27-* pp* *-win32

change to 

        CIBW_SKIP: cp27-* pp* *-win32 cp35-*
bobfang1992 commented 3 years ago

Hi I fixed this can you rebase and then you should be fine?

bobfang1992 commented 3 years ago

my MR https://github.com/bobfang1992/pytomlpp/pull/53

bobfang1992 commented 3 years ago

ping @ioistired

ioistired commented 3 years ago

Rebased

ioistired commented 3 years ago

That's odd, I just rebased on top of master, which includes commit 970d1bcee535cc7f34f04b513c64e379e976d6fa which upgrades toml++

ioistired commented 3 years ago

What would you like me to do?

marzer commented 3 years ago

@ioistired I believe this should be sufficient:

cd third_party/tomlplusplus && git checkout d962c6ccc1241a3906642c071d27b11a031471b4
ioistired commented 3 years ago

How's that?

marzer commented 3 years ago

Yup, looking good.

bobfang1992 commented 3 years ago

One question, so if I merge this and then I do pip install pytomlpp what do I get? The binary version or the source dist? What controls the behaviour? Thanks! @ioistired

ioistired commented 3 years ago

What controls the behavior?

Whether there's a binary distribution available for your platform. Pip prefers binary distributions by default. If there's no wheel for your platform it will download and try to compile the source.

bobfang1992 commented 3 years ago

What controls the behavior?

Whether there's a binary distribution available for your platform. Pip prefers binary distributions by default. If there's no wheel for your platform it will download and try to compile the source.

Cool, this one needs a fairly new compiler toochain so I am not sure how many python guys will have that installed. But anyway this is a good addition and I will merge it now.