search

bobfang1992 / pytomlpp

A python wrapper for tomlplusplus
https://bobfang1992.github.io/pytomlpp/pytomlpp.html
MIT License
86 stars 11 forks source link

updating toml++ to v3 #62

Closed marzer closed 2 years ago

marzer commented 2 years ago

@bobfang1992 please don't merge this in just yet as toml++ v3 is still in development. I'm just using this PR as a hook into your CI to make sure things work OK. I'll update the PR when I release v3 properly ^_^

marzer commented 2 years ago

Damn, your CI kicked my ass, lol. Took me 8 separate force-pushes before it came up green.

bobfang1992 commented 2 years ago

@marzer yeah we are supporting quite a few platforms so haha sometimes people do get caught with it.

bobfang1992 commented 2 years ago

@marzer And congratulation on beating rtoml :) wondering if you did some optimisation specifically on v3 side or it is simply using std::move made it fast. But great showing C++ is still faster than Rust.

marzer commented 2 years ago

Thanks! I did a lot of work in the parser to eliminate a number of unnecessary string allocations, and added a SIMD fast-path to the unicode decoder.

marzer commented 2 years ago

@bobfang1992 I released toml++ v3 earlier and have updated this PR accordingly. I'll let you do the honours ^_^

bobfang1992 commented 2 years ago

@marzer Hi, congratulations! Quite an achievement. I will merge this now!