search

bobharley / facebook-md

material design for facebook
1 stars 6 forks source link

Fixed the image link #6

Closed email2vimalraj closed 6 years ago

email2vimalraj commented 6 years ago

The image link was broken and fixed now

bobharley commented 6 years ago

It works just fine

email2vimalraj commented 6 years ago

@bobharley : No, the link doesn't work when I click from github.

Refer the below image, and see the hovered link in the left bottom, it points to fm-md.png instead of fb-md.png.

screen shot 2017-10-08 at 10 26 35 pm

When I click on the image link, I get Page not found:

screen shot 2017-10-08 at 10 26 45 pm
bobharley commented 6 years ago

I've updated it myself, it works fine now. If you want to contribute, please follow the guidelines.

email2vimalraj commented 6 years ago

Great! If there is a mistake done by the contributor, I would help them to understand the mistake and correct it by themselves. If I missed following guidelines, you would have let me know and I'll happily update the commit with what should I've followed. Thanks for demotivating me in contributing.

bobharley commented 6 years ago

Demotivating you? Dude, you just removed like 6 characters from the readme.md

email2vimalraj commented 6 years ago

Dude, I fixed the problem that you never observed. Readme is the user facing and should give appropriate information. 6 or 1000 characters shouldn't be a deciding factor of the contribution.

On 09-Oct-2017 7:52 AM, "Harley Dela Cruz" notifications@github.com wrote:

Demotivating you? Dude, you just removed like 6 characters from the readme.md

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/bobharley/facebook-md/pull/6#issuecomment-335056479, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKI3vaua3VE-nbZ2sEVml2S_e_OioIFks5sqYN7gaJpZM4PxPnf .

bobharley commented 6 years ago

Your fork is behind the master branch. It was easier to fix the "readme.md" file myself. I'm sure you're still motivated to find typos on other people's readme.md files. Don't worry, your PR still counts for the hacktoberfest.

If you want to "actually" contribute, "read and follow" the guidelines and also read the issues on the issues page. Thanks!

bobharley commented 6 years ago

"never observed" how did you know?