Closed shallwefootball closed 4 years ago
This might be a fault in my documentation, but I think this is intended?
no_override
is 'true'
, so noOverride = ('true' === 'true') = true
and we do not override the previous deployment (so deactivateEnvironment
does not run)no_override
should be false
, then noOvverride = ('false' === 'true') = false
and deactivateEnvironment
does runI might be a bit confused myself because I checked our config and we don't make use of this feature at the moment (we leave it to the default value)
default of
no_override
options istrue
if input ture
'true' === 'true';
istrue
so can't run this code
https://github.com/bobheadxi/deployments/blob/cd00cf0d7017db4994a9e8a9ea6de21614bdc382/src/main.ts#L27-L29
that is incorrect.
so change for run default