bobheadxi / deployments

🔖 GitHub Action for working painlessly with deployment statuses
https://github.com/marketplace/actions/github-deployments
MIT License
385 stars 64 forks source link

fix true to false #10

Closed shallwefootball closed 4 years ago

shallwefootball commented 4 years ago

default of no_override options is true

if input ture 'true' === 'true'; is true

so can't run this code

https://github.com/bobheadxi/deployments/blob/cd00cf0d7017db4994a9e8a9ea6de21614bdc382/src/main.ts#L27-L29

that is incorrect.

so change for run default

bobheadxi commented 4 years ago

This might be a fault in my documentation, but I think this is intended?

I might be a bit confused myself because I checked our config and we don't make use of this feature at the moment (we leave it to the default value)