bobheadxi / deployments

🔖 GitHub Action for working painlessly with deployment statuses
https://github.com/marketplace/actions/github-deployments
MIT License
385 stars 64 forks source link

fix: delete env from settings #134

Closed devthejo closed 1 year ago

devthejo commented 1 year ago

fix https://github.com/bobheadxi/deployments/issues/118

ai commented 1 year ago

@bobheadxi need this PR a lot since the current deployment become slower and slower after every deploy

devthejo commented 1 year ago

just tested here: https://github.com/SocialGouv/deployments/actions/runs/3954292536 and it works nicely

bobheadxi commented 1 year ago

There is also an issue with the build: https://github.com/bobheadxi/deployments/actions/runs/3954512017/jobs/6771995515

devthejo commented 1 year ago

There is also an issue with the build: https://github.com/bobheadxi/deployments/actions/runs/3954512017/jobs/6771995515

First I was making build with node v18 (default on my machine), but the updated workflow on my fork wasn't OK, so I've tested after nvm use 16 then it was passing, I've just tested with node 12, but no changes in diff, so I don't know what's the difference

I can remove the dist changes from the PR, you can merge, rebuid the dist yourself and push, that would be OK for you ?

bobheadxi commented 1 year ago

I upgraded deps/pipelines/etc and ran the rebuild, and cut a new release with this fix: https://github.com/bobheadxi/deployments/releases/tag/v1.4.0 , thanks!