search

bobheadxi / gobenchdata

📉 Run Go benchmarks, publish results to an interactive web app, and check for performance regressions in your pull requests
https://gobenchdata.bobheadxi.dev
MIT License
142 stars 14 forks source link

Fix Parser panic when runner reports cpu #49

Closed piotrekmonko closed 2 years ago

piotrekmonko commented 2 years ago

Some Github runners report, in addition to and after pkg: line, also the CPU name on which the benchmarks are run which results in a panic which this proposed PR fixes:

panic: cpu: Intel(R) Xeon(R) Platinum 8275CL CPU @ 3.00GHz: could not parse run: strconv.Atoi: parsing "": invalid syntax (line: cpu: Intel(R) Xeon(R) Platinum 8275CL CPU @ 3.00GHz)
piotrekmonko commented 2 years ago

This fixes issue https://github.com/bobheadxi/gobenchdata/issues/47

bobheadxi commented 2 years ago

Closes https://github.com/bobheadxi/gobenchdata/pull/48

codecov[bot] commented 2 years ago

Codecov Report

Merging #49 (56788e6) into master (45436a7) will decrease coverage by 1.35%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
- Coverage   32.65%   31.30%   -1.34%     
==========================================
  Files           8        8              
  Lines         481      441      -40     
==========================================
- Hits          157      138      -19     
+ Misses        306      285      -21     
  Partials       18       18
Impacted Files Coverage Δ
bench/parser.go 63.24% <100.00%> (+0.57%) :arrow_up:
checks/config.go 59.10% <0.00%> (-2.44%) :arrow_down:
io.go 9.90% <0.00%> (-1.99%) :arrow_down:
checks/evaluate.go 69.39% <0.00%> (-0.98%) :arrow_down:
main.go 0.00% <0.00%> (ø)
merge.go 0.00% <0.00%> (ø)
checks/generate.go 0.00% <0.00%> (ø)
bench/benchmark.go 50.00% <0.00%> (+7.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45436a7...56788e6. Read the comment docs.