Clicking on chart doesn't open commit version

bobheadxi / gobenchdata

📉 Run Go benchmarks, publish results to an interactive web app, and check for performance regressions in your pull requests

https://gobenchdata.bobheadxi.dev

MIT License

142 stars 14 forks source link

Closed josephgardner closed 2 years ago

josephgardner commented 2 years ago

I've updated my template to version 1.1.0 by re-running generate,

gobenchdata web generate .

However clicking points on the graph no longer launches the repo URL.

Running serve exhibits the same behavior,

gobenchdata web serve

Are changes to the config required to upgrade the web template?

bobheadxi commented 2 years ago

Hey! Do you mind sharing your config so I can attempt to reproduce? What version of the template are you attempting to upgrade from?

The demo at https://gobenchdata.bobheadxi.dev/, which is generated from v1.1.0, appears to have click-to-commit working correctly

josephgardner commented 2 years ago

I'll try to reproduce with a fresh install and report back.

bobheadxi commented 2 years ago

I was able to reproduce this actually, investigating!

bobheadxi commented 2 years ago