bobjflong / yesod-csp

add CSP headers to Yesod apps
MIT License
8 stars 4 forks source link

compilation failure with text 1.2.5.0 (ghc 9.0.2) #8

Open bergmark opened 2 years ago

bergmark commented 2 years ago
[1 of 3] Compiling Yesod.Csp    

src/Yesod/Csp.hs:81:27: error:
    Ambiguous occurrence ‘elem’
    It could refer to
       either ‘Prelude.elem’,
              imported from ‘Prelude’ at src/Yesod/Csp.hs:5:8-16
              (and originally defined in ‘Data.Foldable’)
           or ‘Data.Text.elem’,
              imported from ‘Data.Text’ at src/Yesod/Csp.hs:24:1-26
   |
81 | notEscapable = not . flip elem toEscape
   |                           ^^^^

src/Yesod/Csp.hs:110:24: error:
    Ambiguous occurrence ‘elem’
    It could refer to
       either ‘Prelude.elem’,
              imported from ‘Prelude’ at src/Yesod/Csp.hs:5:8-16
              (and originally defined in ‘Data.Foldable’)
           or ‘Data.Text.elem’,
              imported from ‘Data.Text’ at src/Yesod/Csp.hs:24:1-26
    |
110 | filterOut x | Wildcard `elem` x = Wildcard :| []
    |                        ^^^^^^

src/Yesod/Csp.hs:111:20: error:
    Ambiguous occurrence ‘elem’
    It could refer to
       either ‘Prelude.elem’,
              imported from ‘Prelude’ at src/Yesod/Csp.hs:5:8-16
              (and originally defined in ‘Data.Foldable’)
           or ‘Data.Text.elem’,
              imported from ‘Data.Text’ at src/Yesod/Csp.hs:24:1-26
bobjflong commented 10 months ago

I apologise for the extreme delay getting back to you. I probably need to find a new owner of this package. @bergmark is that something you'd be interested in? If so please fork and I will direct the readme to your version.

pSub commented 9 months ago

Hi @bobjflong,

would be interested in maintaining yesod-csp. I use it for several small side projects and this compilation failure is currently blocking me. I already forked the repository at https://github.com/pSub/yesod-csp containing the fix for this issue and a Github action that tries to build the package. Only my Hackage account seems to be broken. I haven't used it in a long time and the "re-enabling"-thing I have to do breaks. But I have contacted the Hackage admins about this and hope they can sort it out.

What do you think?

bobjflong commented 9 months ago

Hi @pSub - yeah that's fine with me. I can add a note to the readme, and if you give me a hackage account I can add you to the maintainers there I believe.

pSub commented 9 months ago

Thank you. As mentioned above my Hackage account (PascalWittmann) is currently unusable. I hope it the Hackage admins are able to fix it soon. Once I can login to Hackage, I'll ping you to add me as a maintainer.

pSub commented 8 months ago

Hi @bobjflong,

thanks to the hackage admins I'm able to use my Hackage account (PascalWittmann) again. You can add me as a maintainer for yesod-csp and refer to https://github.com/pSub/yesod-csp in the Readme. I'm happy to take over.

bobjflong commented 8 months ago

@pSub added https://hackage.haskell.org/package/yesod-csp/maintainers/

pSub commented 8 months ago

Thank you! I have uploaded a new version yesod-csp-0.2.6.0 (https://hackage.haskell.org/package/yesod-csp-0.2.6.0) to Hackage which fixes this issue.