search

boblauer / react-onclickout

An ES6-friendly on-click-outside React component.
MIT License
92 stars 14 forks source link

Fix #6 #7

Closed grassick closed 8 years ago

grassick commented 9 years ago

I haven't actually tested this (sorry, one of those days), but it should prevent the unnecessary adding of a listener and it's really simple.

grassick commented 9 years ago

Ok, tested and works great!

boblauer commented 8 years ago

Thanks!

grassick commented 8 years ago

That's strange... I don't see these changes in master. Master still has the delaying binding issue in that setTimeout will run the next tick and leave a listener behind.

boblauer commented 8 years ago

see my comment here - https://github.com/boblauer/react-onclickout/issues/6#issuecomment-158823487