search

boblemaire / IoTaWatt

IoTaWatt Open WiFi Electric Energy Monitor
https://iotawatt.com
GNU General Public License v3.0
647 stars 179 forks source link

Fix README image paths, improve SD UX #311

Closed samyk closed 3 years ago

samyk commented 3 years ago
samyk commented 3 years ago

Hi @boblemaire, thanks for this great project! Let me know if you're interested in PRs or if you have specific requirements on them. I didn't see any on the site/wiki/git, and I see my changes now have conflicts since updates have been made since my initial PR so I'm trying to determine whether I should continue to make my changes based on your version or if I should fork from here. Thanks!

boblemaire commented 3 years ago

@samyk,

I don't have a formal policy on PRs. I appreciate fixing the broken links, but marrying that to splitting index.htm into two files is not anything I am inclined to go along with. I admit that index.htm is a monster that has grown over the years, but simply splitting it doesn't do anything to improve the situation, and introduces yet more opportunity for problems if the distributed .htm doesnt match the .js. I don't have a good version control system for that, so keeping them together eliminates the problem.

samyk commented 3 years ago

@boblemaire Thanks. I didn't mean to put them together, I submitted the broken img PR, then continued making changes and github keeps updating the PR with whatever I make to my own repo :) I need to figure out how to split them out, maybe via branches.

On the note of splitting the files, splitting individual files allows various automatic optimizations like HTTP file caching, improved support across code editors, etc. Isn't git the version control system? All the other HTML files are already depending on external JS/CSS files. I'm confused as to how one can be updated and not another?

boblemaire commented 3 years ago

I update those files directly on the IoTaWatt using the file manager and ACE editor. So it all depends on when I download them and put them into the git. If they are the same file, I’m less likely to mess that up.

On Oct 3, 2021, at 9:17 PM, Samy Kamkar @.***> wrote:

 @boblemaire Thanks. I didn't mean to put them together, I submitted the broken img PR, then continued making changes and github keeps updating the PR with whatever I make to my own repo :) I need to figure out how to split them out, maybe via branches.

On the note of splitting the files, splitting individual files allows various automatic optimizations like HTTP file caching, improved support across code editors, etc. Isn't git the version control system? All the other HTML files are already depending on external JS/CSS files. I'm confused as to how one can be updated and not another?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

Onepamopa commented 3 years ago

@boblemaire by the way, how can we order from Bulgaria? Last time I checked it's in the EU, but weirdly enough - not listed in your store?!?

boblemaire commented 3 years ago

@boblemaire by the way, how can we order from Bulgaria? Last time I checked it's in the EU, but weirdly enough - not listed in your store?!?

This is a PR. Please ask about this in the forum.

Onepamopa commented 3 years ago

@boblemaire the forum is broken... like .. a lot. I've got an account there but can't login, can't reset password, can't register. Errors - all the time.

boblemaire commented 3 years ago

No progress on this. Splitting index.htm is not going to happen.