search

boblemaire / asyncHTTPrequest

asynchronous HTTP for ESP using ESPasyncTCP. Works like XMLHTTPrequest in JS.
GNU General Public License v3.0
65 stars 31 forks source link

URL without trailing '/' after address causes crash on ESP32 #30

Closed thorlancaster closed 3 years ago

thorlancaster commented 4 years ago

When attempting to connect to a HTTP server, I found that URLs where the address portion was not ended with a '/' character caused a crash.

URLs that cause crash: http://172.105.151.207, http://172.105.151.207:1230, http://172.105.151.207:1230?foo=bar URLs that don't cause crash: http://172.105.151.207/, http://172.105.151.207:1230/, http://172.105.151.207:1230/?foo=bar.

(Note: The IP address, especially port 1230, will likely change in the future, but I hope you see the pattern).

It's easy enough to fix on my end by adding a '/' to the URL between the address and the arguments, but this shouldn't be happening.

boblemaire commented 3 years ago

Resolved in rewrite of parseURL PR#32