search

bobo1on1 / boblight

Automatically exported from code.google.com/p/boblight
GNU General Public License v3.0
11 stars 11 forks source link

Patch to support KarateLight devices #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi,

since I could not find another way to send in a patch, I am using the Tracker :)

Attached is a patch that adds support for 'KarateLight' devices. It is a 8 (or 
with extension-pcb 16Channels) RGB-Dimmer.
Schematics and Firmware can be found here:
http://ca.rstenpresser.de/~cpresser/data/karate/

Without the patch the prefix and color data were send in two messages. Since 
Karatelight expects this to be just one message, I have changed the code to 
always send the prefix and color-data in one burst. This should not break other 
devices.
At least, the AtmoLight device still works fine with the patch applied.

Greetings
Carsten

Original issue reported on code.google.com by c...@rstenpresser.de on 10 Dec 2010 at 2:36

Attachments:

GoogleCodeExporter commented 9 years ago 
Nice, but why the change of putting the prefix in the buffer?

Original comment by bob.loo...@gmail.com on 10 Dec 2010 at 8:56

GoogleCodeExporter commented 9 years ago 
The Firmware has no state-maschine working the serial input. So the 
whole input needs to be processed at once.

I could change the KarateLight firmware, but I dont see a particular 
reason why one sould send the prefix and the data in two bursts. So I 
changed the boblightd code :)

Original comment by c...@rstenpresser.de on 10 Dec 2010 at 9:29

GoogleCodeExporter commented 9 years ago 
I've added the first part of the patch in r333.

Original comment by bob.loo...@gmail.com on 10 Dec 2010 at 9:33

GoogleCodeExporter commented 9 years ago 
I agree that this is a nice optim, but it won't guarantee that the data gets 
sent in one burst.

Original comment by bob.loo...@gmail.com on 10 Dec 2010 at 9:42

GoogleCodeExporter commented 9 years ago 
Please use whichever is most robust for enduser!

Original comment by pikest...@gmail.com on 10 Dec 2010 at 9:49

GoogleCodeExporter commented 9 years ago 
Fixed in r337.
Now someone just needs to test it I suppose.

Original comment by bob.loo...@gmail.com on 10 Dec 2010 at 9:56

GoogleCodeExporter commented 9 years ago

Original comment by bob.loo...@gmail.com on 11 Dec 2010 at 11:20

GoogleCodeExporter commented 9 years ago

Original comment by bob.loo...@gmail.com on 2 Jul 2011 at 2:13