search

boboldehampsink / import

DEPRECATED - Import plugin for Craft CMS
MIT License
177 stars 28 forks source link

entries can now be related based on ID. #164

Open damianDauntless opened 7 years ago

damianDauntless commented 7 years ago

This will allow the imported entry to create relationship if we pass ID of the entry we want to relate to. This is possible with is_numeric as prepEntriesFieldType will now search if there is any variations of string otherwise default to ID lookup if is_numeric returns true.

boboldehampsink commented 7 years ago

Thanks! Please use PSR-2 code style and fix the chmod.

damianDauntless commented 7 years ago

@boboldehampsink please can you tell me what do I need to fix with chmod? thanks!

boboldehampsink commented 7 years ago

Run chmod 0644 ImportService.php

boboldehampsink commented 7 years ago

And can you keep the newlines you just removed? I like them ;-)

damianDauntless commented 7 years ago

@boboldehampsink all done! thanks a lot for amazing plugin dude!

boboldehampsink commented 7 years ago

For some reason you changed the chmod again ;-)

boboldehampsink commented 7 years ago

This should probably apply to other elements as well

damianDauntless commented 7 years ago

@boboldehampsink you mean chmod entire project? if so what is dir chmod you want?

boboldehampsink commented 7 years ago

No I mean search by id for all elements, not only entries

damianDauntless commented 7 years ago

yep I can look into it maybe later on today when I have some spare time. I guess it would be good to implement it for Categories and Assets too.