search

bobolounna / restfb

Automatically exported from code.google.com/p/restfb
0 stars 0 forks source link

Log level too high for makeRequestAndProcessResponse (producing gigs of logs per server instance) #146

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Normal usage of DefaultFacebookClient produces too much logging.

What is the expected output? What do you see instead?
No output unless something goes wrong or debug logging is enabled.

What version of the product are you using? On what operating system?
1.6 however the latest version of restfb exhibits the same behaviour.

Please provide any additional information below.
Please see attached patch for proposed fix.

Original issue reported on code.google.com by johno.cr...@gmail.com on 25 Jul 2011 at 3:27

Attachments:

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Would it be possible to turn down the log level for DefaultFacebookClient in 
your logging.properties file?

Original comment by m...@xmog.com on 29 Jul 2011 at 6:32

GoogleCodeExporter commented 8 years ago 
Yes, however not a long term solution. If further logging is added to the 
DefaultFacebookClient class it may be desirable to see those messages at INFO 
level.

Original comment by johno.cr...@gmail.com on 29 Jul 2011 at 7:58

GoogleCodeExporter commented 8 years ago 
Is there a reason for not accepting the proposed patch? From my stand point any 
application logging such verbose information everytime a user authenticates is 
not production ready.

Original comment by johno.cr...@gmail.com on 18 Oct 2011 at 3:12

GoogleCodeExporter commented 8 years ago 
I support this issue. INFO is not the appropriate log level for this as the 
information being logged should be relevant only for tracing. The JUL Javadoc 
states: "FINE is a message level providing tracing information.".

Original comment by marcel@frightanic.com on 23 Oct 2011 at 8:49

GoogleCodeExporter commented 8 years ago 
Discussion moved to https://github.com/revetkn/restfb/pull/2

Original comment by m...@xmog.com on 27 Oct 2011 at 8:26

GoogleCodeExporter commented 8 years ago 
This is also a security issue if you are logging things like access tokens into 
the logs.

The log level for some of these in in appropriate.
The right level for most of these is debug. Some of these should be in trace.

Original comment by tapasvi....@gmail.com on 3 Nov 2011 at 9:00

GoogleCodeExporter commented 8 years ago 
Per the github issue, I will be making this change for 1.6.10.

Original comment by m...@xmog.com on 3 Nov 2011 at 9:30

GoogleCodeExporter commented 8 years ago 
I think we're good now, finally marking fixed.

Original comment by m...@xmog.com on 1 Sep 2012 at 3:52