search

bobosch / ods_osm

TYPO3 Extension OpenStreetMap
10 stars 22 forks source link

Extending calendarize in TYPO3 12.4 broken #153

Closed hannesbochmann closed 11 months ago

hannesbochmann commented 11 months ago

In a TYPO3 12.4 with calendarize I get the following error which breaks the whole environment:

Class "TYPO3\CMS\Extbase\Object\Container\Container" not found in ext_localconf.php line 103

One thing is to fix extending the calendarize model which basically means just to remove the registerImplementation call. Another thing would be to make the extending optional. If you have a own extension of the event model only one can be used which is bad.

If it's okay for you I would add a extension configuration to enable extending calendarize which is disabled by default. And I would fix the extending itself.

albig commented 11 months ago

The support of calendarize in ods_osm with TYPO3 12.4 might be broken because there was no calendarize version compatible with TYPO3 12.4 as I released ods_osm 4.2..0 for TYPO3 12.

So yes, If you have a fix, this will be welcome.

albig commented 11 months ago

Thank you @hannesbochmann for your PR #154. This works of course.

When I was playing around with your fix, I wondered why I introduced extending the calendarize event model at all. It seems to work as is.

Could you verify my PR #155 works for you?

hannesbochmann commented 11 months ago

@albig Yes, the PR works for me.

albig commented 11 months ago

Thank you. Than I merge this one and close yours.