search

bobosch / ods_osm

TYPO3 Extension OpenStreetMap
10 stars 22 forks source link

[TASK] Delete MapSurfer.Net #165

Closed simonschaufi closed 7 months ago

simonschaufi commented 7 months ago

They shut down their service in June 2020.

See https://ask.openrouteservice.org/t/mapsurfer-deprecation-cached-tiles-removed-after-june-2020/1704

albig commented 7 months ago

The records are already marked as deleted. Of course, we could purge theme completely, as you suggest.

simonschaufi commented 7 months ago

Let's keep the file clean ;) No need to import deleted records

albig commented 7 months ago

Not yet convinced. I continued the initial approach to disable old tile sources. Especially, you shouldn't touch the UIDs of the tile layer. This may lead to extra confusion if someone purge the layers and import it again, but the plugins just use the UID to select hte layer. That's all not perfect and I would like to have a "Wizard" to update used layers, but for now, I don't see any advantage for this PR.

simonschaufi commented 7 months ago

The layers are actually hidden and NOT deleted. If they would be deleted, then it would be a different story. This service should not be possible to be activated anymore as it is completely shut down.

The uids will stay the same as you don't import NULL as uid.

simonschaufi commented 7 months ago

@albig What would be a reason to keep these records?

The uids will stay the same after another import as you don't import NULL as uid.

bobosch commented 7 months ago

The other uid's don't change, and nobody will have an non-working layer configured in the frontend plugin - so I think it is safe to remove them from the import file.

bobosch commented 7 months ago

@simonschaufi Thanks for your support!