search

bobosch / ods_osm

TYPO3 Extension OpenStreetMap
10 stars 22 forks source link

FlexForm field `enable_scrollwheelzoom` has no effect #166

Open simonschaufi opened 7 months ago

simonschaufi commented 7 months ago

The FlexForm field enable_scrollwheelzoom has no effect.

The setting is actually activated via TypoScript:

plugin.tx_odsosm_pi1 {
    enable_scrollwheelzoom = 1
}

thus it is always activated and can NOT be deactivated because of the way how the overwrite is called:

https://github.com/bobosch/ods_osm/blob/fbe6a009bda941bfdd737036eea5692da0d3645e/Classes/Controller/PluginController.php#L156

The problem here is the last false which ignores 0 values and thus deactivated values cannot deactivate the values from TypoScript but the Flexform values should be the strongest.

Is this the expected behavior? If so, then the FlexForm setting could be removed as it is useless. It only has an effect if the TypoScript value would set to 0 by someone else and then activate the FlexForm setting again individually.

What do you think?